caldav-shares-with-circles

[ArtificialOwl]

No description provided.

[codecov]

Codecov Report

Merging #5638 into master will decrease coverage by 46.51%.
The diff coverage is 0%.

@@ Coverage Diff @@## master #5638 +/- ##
============================================
- Coverage 53.81% 7.29% -46.52% - Complexity 22668 22784 +116 
============================================
Files 1404 1408 +4 Lines 86643 86344 -299 Branches 1328 1328 ============================================
- Hits 46625 6302 -40323 - Misses 40018 80042 +40024

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/lib/CalDAV/CalDavBackend.php	0% <ø> (-86.04%)	218 <0> (ø)
apps/dav/lib/Circles/CalDAVEventsBroadcaster.php	0% <0%> (ø)	7 <7> (?)
apps/dav/lib/Connector/Sabre/Principal.php	0% <0%> (-98.04%)	20 <0> (+1)
apps/dav/lib/Server.php	0% <0%> (-47.06%)	12 <0> (ø)
apps/dav/lib/RootCollection.php	0% <0%> (-95.66%)	1 <0> (ø)
apps/dav/lib/Circles/CalDAVSharesBroadcaster.php	0% <0%> (ø)	10 <10> (?)
apps/dav/lib/CalDAV/Calendar.php	0% <0%> (-72.3%)	60 <8> (+8)
apps/dav/lib/DAV/CirclePrincipalBackend.php	0% <0%> (ø)	20 <20> (?)
lib/private/Hooks/PublicEmitter.php	0% <0%> (-100%)	1% <0%> (ø)
apps/files/lib/Activity/Settings/FileChanged.php	0% <0%> (-100%)	8% <0%> (ø)
... and 838 more

[dtygel]

Hi @daita . Let me understand this PR. Is the Circles' payload going to save the new share in oc_dav_shares table locally?

[MorrisJobke]

@daita What is the status of this? You opened a PR with very few descriptions and it looks abandoned. Either we try to get this in or close it. If you need feedback then we should get the people in for reviews. ;)

[ArtificialOwl]

let's close this, i will come back later.