Skip to content

[stable31] feat(scanner): enable use of a setting to disable DB transaction - #56388

Closed
backportbot[bot] wants to merge 1 commit into
stable31from
backport/56383/stable31
Closed

[stable31] feat(scanner): enable use of a setting to disable DB transaction#56388
backportbot[bot] wants to merge 1 commit into
stable31from
backport/56383/stable31

Conversation

@backportbot

@backportbotbackportbotBot commented Nov 12, 2025

Copy link
Copy Markdown

Backport of #56383

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot
backportbotBot requested a review from mgallienNovember 12, 2025 11:22
@backportbotbackportbotBot added the 3. to review Waiting for reviews label Nov 12, 2025
@backportbotbackportbotBot added this to the Nextcloud 31.0.11 milestone Nov 12, 2025
@artonge
artongeforce-pushed the backport/56383/stable31 branch from 81de305 to a916c38CompareNovember 12, 2025 11:31
@mgallien
mgallienforce-pushed the backport/56383/stable31 branch from a916c38 to a293480CompareNovember 12, 2025 17:56
@artonge
artongeforce-pushed the backport/56383/stable31 branch from a293480 to 7f0d42dCompareNovember 14, 2025 14:46
@artonge
artonge marked this pull request as ready for review November 14, 2025 14:52
while doing a files scan from storage, we may want not to use DB transactions
enable the use of a setting for that
define filescanner_no_transactions in system config to enable this (i.e. in config.php)
Signed-off-by: Matthieu Gallien <matthieu.gallien@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
@artonge
artongeforce-pushed the backport/56383/stable31 branch from 7f0d42d to 3273354CompareNovember 14, 2025 14:53

@artongeartonge left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until parent PR is merged.

@artonge

Copy link
Copy Markdown
Collaborator

/backport! to stable30

@backportbot

Copy link
Copy Markdown
Author

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30
# Create the new backport branch
git checkout -b backport/56388/stable30
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 3273354c
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56388/stable30

Error: Failed to push branch backport/56388/stable30: remote: Invalid username or token. Password authentication is not supported for Git operations.
fatal: Authentication failed for 'https://github.com/nextcloud/server.git/'


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nextcloud-botnextcloud-bot mentioned this pull request Feb 4, 2026
@nextcloud-botnextcloud-bot mentioned this pull request Feb 11, 2026
@AndyScherzingerAndyScherzinger removed this from the Nextcloud 31.0.14 milestone Feb 12, 2026
@artonge
artonge marked this pull request as draft April 3, 2026 12:21
@artonge

Copy link
Copy Markdown
Collaborator

Closing as transactions were removed altogether.

@artongeartonge closed this Apr 29, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbackport-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@artonge@mgallien@AndyScherzinger@joshtrichards@blizzz@Altahrim