Uh oh!
There was an error while loading. Please reload this page.
refactor(files): migrate to new NcForm* components (app settings design) - #56408
Merged
Conversation
NcForm* components (app settings design)susnuxforce-pushed
the
refactor/files-settings
branch
from
November 12, 2025 20:08
f18563d to
8cf8ddbComparesusnuxforce-pushed
the
refactor/files-settings-design
branch
from
November 12, 2025 20:10
f0754f0 to
bfaf455Comparesusnuxforce-pushed
the
refactor/files-settings
branch
from
November 13, 2025 10:36
8cf8ddb to
a15adb1CompareShGKme
reviewed
Nov 13, 2025
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
Just a reminder, in Vue 2 you need to add :legacy="false" to the NcAppSettingsDialog
susnux
commented
Nov 13, 2025
ContributorAuthor
already done |
susnuxforce-pushed
the
refactor/files-settings-design
branch
from
November 13, 2025 12:57
bfaf455 to
19f60a2Comparesusnux
marked this pull request as ready for review
November 13, 2025 12:57
susnux
requested review from
artonge, nfebe and sorbaugh
and removed request for
a teamNovember 13, 2025 12:57
ShGKme
approved these changes
Nov 13, 2025
ShGKme
left a comment
Contributor
There was a problem hiding this comment.
Can approve from the new component usage side
susnuxforce-pushed
the
refactor/files-settings-design
branch
from
November 13, 2025 22:09
264392c to
5f4dd0eCompareSigned-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
refactor/files-settings-design
branch
from
November 14, 2025 12:11
5f4dd0e to
ad0beefCompareUh oh!
There was an error while loading. Please reload this page.
susnux
commented
Nov 14, 2025
ContributorAuthor
/backport to stable32 |
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/56408/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick d1b00335 82237a8b ad0beef0
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56408/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the new files app settings design.
Checklist
3. to review, feature component)stable32)