Uh oh!
There was an error while loading. Please reload this page.
[stable32] fix(core): RTL legacy snapper width - #56448
Merged
Merged
Conversation
paulijar
approved these changes
Nov 14, 2025
susnuxforce-pushed
the
backport/56425/stable32
branch
from
November 16, 2025 15:30
acad1b4 to
fd473f2Comparesusnux
approved these changes
Nov 16, 2025
susnux
commented
Nov 16, 2025
Contributor
/compile |
susnux
marked this pull request as ready for review
November 16, 2025 15:30
susnux
requested review from
nfebe, skjnldsv and sorbaugh
and removed request for
a teamNovember 16, 2025 15:30
nextcloud-commandforce-pushed
the
backport/56425/stable32
branch
from
November 16, 2025 15:37
fd473f2 to
a8f9211Comparesusnuxforce-pushed
the
backport/56425/stable32
branch
from
November 17, 2025 11:08
a8f9211 to
7207354Compareskjnldsv
approved these changes
Nov 18, 2025
paulijar
commented
Nov 29, 2025
Contributor
Is there something blocking this PR from being merged? |
susnux
commented
Nov 29, 2025
Contributor
it conflicts and needs to be rebased |
After ec9e283 there was still such a problem with the legacy app navigation snapper that its width was only 266 px on the RTL layout instead of the normal 300 px. The 266 px is the default width of Snap.js module. While the left side snapper width is configured with the property maxPosition, the right side snapper is configured by passing a negative value for the property minPosition. Signed-off-by: Pauli Järvinen <pauli.jarvinen@gmail.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
paulijarforce-pushed
the
backport/56425/stable32
branch
from
November 29, 2025 15:41
7207354 to
195f532Comparepaulijar
commented
Nov 29, 2025
Contributor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #56425
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.