Skip to content

feat: Add option to update the public key of a user - #56451

Merged
SystemKeeper merged 1 commit into
masterfrom
feat/noid/update-user-keys
Nov 19, 2025
Merged

feat: Add option to update the public key of a user#56451
SystemKeeper merged 1 commit into
masterfrom
feat/noid/update-user-keys

Conversation

@SystemKeeper

@SystemKeeperSystemKeeper commented Nov 14, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Add --update option to occ user:keys:verify to allow updating the public key, in case it's different from the derived public key.

Checklist

@SystemKeeperSystemKeeper added this to the Nextcloud 33 milestone Nov 14, 2025
@SystemKeeper

SystemKeeper commented Nov 14, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

@SystemKeeper

SystemKeeper commented Nov 14, 2025

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@SystemKeeper
SystemKeeper marked this pull request as ready for review November 14, 2025 23:36
@SystemKeeper
SystemKeeper requested a review from a team as a code ownerNovember 14, 2025 23:36
@SystemKeeper
SystemKeeper requested review from ArtificialOwl, CarlSchwan, icewind1991 and provokateurin and removed request for a teamNovember 14, 2025 23:36
provokateurin
provokateurin requested changes Nov 17, 2025
View reviewed changes
Comment threadlib/private/Security/IdentityProof/Manager.php Outdated
Comment threadlib/private/Security/IdentityProof/Manager.php Outdated
Comment threadcore/Command/User/Keys/Verify.php
@SystemKeeper
SystemKeeperforce-pushed the feat/noid/update-user-keys branch 2 times, most recently from a8fe7fe to 668be8aCompareNovember 18, 2025 08:58
@SystemKeeper
SystemKeeperforce-pushed the feat/noid/update-user-keys branch 2 times, most recently from 360bb94 to df54c4cCompareNovember 18, 2025 09:48
miaulalala
miaulalala approved these changes Nov 19, 2025
View reviewed changes

@miaulalalamiaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick

Comment threadcore/Command/User/Keys/Verify.php Outdated
@SystemKeeper
feat: Add option to update the public key of a user
234f183
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
@SystemKeeper
SystemKeeperforce-pushed the feat/noid/update-user-keys branch from df54c4c to 234f183CompareNovember 19, 2025 09:51
@SystemKeeper
SystemKeeper merged commit 8e04afc into masterNov 19, 2025
205 of 209 checks passed
@SystemKeeper
SystemKeeper deleted the feat/noid/update-user-keys branch November 19, 2025 12:42
This was referenced Nov 19, 2025
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwanCarlSchwan is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancementfeature: users and groups

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@SystemKeeper@nickvergessen@miaulalala@provokateurin