Uh oh!
There was an error while loading. Please reload this page.
[stable32] fix(files): Do not fail on missing sidebar in files list - #56513
Merged
Conversation
backportbotBot
requested review from
eszkadev, juliusknorr, nfebe and susnux
and removed request for
a teamNovember 18, 2025 13:53
skjnldsv
approved these changes
Nov 18, 2025
skjnldsv
commented
Nov 18, 2025
Member
/compile |
AndyScherzinger
commented
Nov 30, 2025
Member
/compile rebase |
When using richdocuments it was failing in case of shared links or when user with opened file did a wheel click on a refresh page. Then new tab appeared but instead opening the file it was doing nothing (showing the list of files) or downloading the file. Make code more defensive. I found these logs while debugging: OCA.Files.Settings initialized Sidebar.js:19 OCA.Files.Sidebar initialized ShareSearch.js:16 OCA.Sharing.ShareSearch initialized comments-app.js:15 OCA.Comments.View initialized index.mjs:54 files: Error while opening sidebar Object log @ index.mjs:54 index.mjs:54 files: Error while opening sidebar Objectapp: "files" TypeError: window.OCA.Files.Sidebar.open is not a function at h.exec (http://nc/dist/files-main.js?v=106d16db-0:1:70123) at o.openSidebarForFile (http://nc/dist/files-main.js?v=106d16db-0:1:163422) at o.handleOpenQueries (http://nc/dist/files-main.js?v=106d16db-0:1:163167) at o.openDetails (http://nc/dist/files-main.js?v=106d16db-0:1:162349) at fn (http://nc/dist/core-common.js?v=106d16db-0:1:3942538) at e.run (http://nc/dist/core-common.js?v=106d16db-0:1:3946900) at sa (http://nc/dist/core-common.js?v=106d16db-0:1:3948728) at Array.<anonymous> (http://nc/dist/core-common.js?v=106d16db-0:1:3943585) at bn (http://nc/dist/core-common.js?v=106d16db-0:1:3942986)level: 2uid: "admin" [[Prototype]]: Object log @ index.mjs:54 Possibly regression from e700102Fixesnextcloud/richdocuments#3815 Signed-off-by: Szymon Kłos <szymon.klos@collabora.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-commandforce-pushed
the
backport/56138/stable32
branch
from
November 30, 2025 18:27
ce7d3f6 to
e679fb3CompareAndyScherzinger
approved these changes
Nov 30, 2025
AndyScherzinger
enabled auto-merge
November 30, 2025 18:47
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #56138
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.