Skip to content

fix(files_reminder): prevent setting reminder in the past - #56520

Merged
skjnldsv merged 2 commits into
masterfrom
fix/past-reminder
Nov 19, 2025
Merged

fix(files_reminder): prevent setting reminder in the past#56520
skjnldsv merged 2 commits into
masterfrom
fix/past-reminder

Conversation

@skjnldsv

@skjnldsvskjnldsv commented Nov 19, 2025•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Somehow it was missing..
If we send the following request:

PUT /ocs/v2.php/apps/files_reminders/api/v1/392 HTTP/1.1
Content-Type: application/json
OCS-APIREQUEST: true
{"dueDate":"2003-10-14T14:00:00.000Z"}

Then we see the observed response: 201 Created and the system shows a reminder message such as:
We will remind you of this file 22 years ago.

Checklist

@skjnldsv
fix(files_reminder): prevent setting reminder in the past
fee82ad
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv
skjnldsv requested a review from a team as a code ownerNovember 19, 2025 08:37
@skjnldsv
skjnldsv requested review from ArtificialOwl, icewind1991, leftybournes and provokateurin and removed request for a teamNovember 19, 2025 08:37
provokateurin
provokateurin approved these changes Nov 19, 2025
View reviewed changes

@provokateurinprovokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚗 ▶️ ⏲️

@skjnldsv

skjnldsv commented Nov 19, 2025

Copy link
Copy Markdown
MemberAuthor

Adding tests ⌛

@skjnldsvskjnldsv self-assigned this Nov 19, 2025
@skjnldsvskjnldsv added this to the Nextcloud 33 milestone Nov 19, 2025
@skjnldsv
chore(files_reminder): add integration tests
32e1d6c
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsvskjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 2. developing Work in progress labels Nov 19, 2025
@skjnldsv
skjnldsv merged commit dc97bc0 into masterNov 19, 2025
186 of 191 checks passed
@skjnldsv
skjnldsv deleted the fix/past-reminder branch November 19, 2025 15:43
@skjnldsv

skjnldsv commented Nov 19, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable31

@skjnldsv

skjnldsv commented Nov 19, 2025

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

This was referenced Nov 19, 2025
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArtificialOwlArtificialOwlArtificialOwl approved these changes
@nfebenfebenfebe approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
+1 more reviewer
@333ordogape333333ordogape333333ordogape333 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@skjnldsvskjnldsv

Labels

4. to releaseReady to be released and/or waiting for tests to finishbugfeature: files_reminders

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv@ArtificialOwl@nfebe@provokateurin@333ordogape333