Skip to content

Add configs for strict PHP checks - #56522

Merged
provokateurin merged 2 commits into
masterfrom
feat/strict-php-checks
Jan 27, 2026
Merged

Add configs for strict PHP checks#56522
provokateurin merged 2 commits into
masterfrom
feat/strict-php-checks

Conversation

@provokateurin

Copy link
Copy Markdown
Member

This is meant for new files in order to have top quality from the start. Of course it can also be used for existing files, but they should go through the normal psalm/rector configs first.

@provokateurinprovokateurin added this to the Nextcloud 33 milestone Nov 19, 2025
@provokateurin
provokateurin requested a review from a team as a code ownerNovember 19, 2025 10:18
@provokateurin
provokateurin requested review from ArtificialOwl and icewind1991 and removed request for a teamNovember 19, 2025 10:18

@CarlSchwanCarlSchwan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For psalm, I am still a bit more in favor or increasing the level and add more stuff to the baseline. This has a bit of the same effect. New code has higher quality requirements, old code has know defect we can slowly get rid of with time.

I feel like for new files, we will always forgot to add them to the list of new files.

@provokateurin

Copy link
Copy Markdown
MemberAuthor

For psalm, I am still a bit more in favor or increasing the level and add more stuff to the baseline. This has a bit of the same effect. New code has higher quality requirements, old code has know defect we can slowly get rid of with time.

I get your point, but we can't just set the level to 1 right now, as it would explode the baseline size. So for new code, it's much easier to have a separate config.

I feel like for new files, we will always forgot to add them to the list of new files.

That is probably true, but for example in my case I want to add whole a new app and it would be really useful to just have it all clean and tidy from the start, even if it's only used for that one app.

Comment threadbuild/rector-strict.php
This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
@nextcloud-botnextcloud-bot mentioned this pull request Jan 22, 2026
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurin
provokateurin merged commit 85ba4e0 into masterJan 27, 2026
213 of 220 checks passed
@provokateurin
provokateurin deleted the feat/strict-php-checks branch January 27, 2026 10:11
@nextcloud-botnextcloud-bot mentioned this pull request Apr 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@provokateurin@CarlSchwan@come-nc