Uh oh!
There was an error while loading. Please reload this page.
fix(sharing): allow federated shares to non-trusted servers - #56652
Merged
Conversation
nfebe
requested review from
artonge, dasisdormax, skjnldsv, susnux and szaimenNovember 25, 2025 09:10
nfebe
commented
Nov 25, 2025
ContributorAuthor
/backport to stable32 |
nfebe
commented
Nov 25, 2025
ContributorAuthor
/backport to stable31 |
nfebeforce-pushed
the
fix/federated-share-external-filter
branch
from
November 25, 2025 09:54
aa52ca4 to
8e788beComparenfebe
commented
Nov 25, 2025
ContributorAuthor
/compile |
nfebe
enabled auto-merge
November 25, 2025 09:55
szaimen
approved these changes
Nov 25, 2025
szaimen
left a comment
Contributor
There was a problem hiding this comment.
Explanation makes sense but did not test
nfebeforce-pushed
the
fix/federated-share-external-filter
branch
from
November 28, 2025 08:32
6ace53e to
56856a2Comparenfebe
commented
Nov 28, 2025
ContributorAuthor
/compile |
artonge
approved these changes
Dec 2, 2025
nfebeforce-pushed
the
fix/federated-share-external-filter
branch
from
December 4, 2025 10:10
69d1f20 to
f41666fComparenfebe
commented
Dec 4, 2025
ContributorAuthor
/compile |
1 similar comment
nfebe
commented
Dec 4, 2025
ContributorAuthor
/compile |
When `showFederatedSharesToTrustedServersAsInternal` is enabled, the trusted server filter was incorrectly applied to both internal and external sharing sections. This prevented users from sharing with federated users on non-trusted servers via the external share UI. The filter now only applies to the internal section, allowing non-trusted federated shares to appear in the external section. Fixes: #56622 Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebeforce-pushed
the
fix/federated-share-external-filter
branch
from
December 10, 2025 16:41
f41666f to
0838228Comparenfebe
commented
Dec 10, 2025
ContributorAuthor
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/56652/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch# This might cause conflicts, resolve them
git cherry-pick 08382282 5de1d46b
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/56652/stable32Error: Failed to check for changes with origin/stable32: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
showFederatedSharesToTrustedServersAsInternalis enabled, the trusted server filter was incorrectly applied to both internal and external sharing sections. This prevented users from sharing with federated users on non-trusted servers via the external share UI.The filter now only applies to the internal section, allowing non-trusted federated shares to appear in the external section.
Fixes: #56622