Uh oh!
There was an error while loading. Please reload this page.
fix(templates): deduplicate provider templates - #56722
Merged
Merged
Conversation
elzody
requested review from
Altahrim, leftybournes, salmart-dev and yemkareems
and removed request for
a teamNovember 26, 2025 18:56
juliusknorr
approved these changes
Nov 26, 2025
elzody
commented
Nov 26, 2025
ContributorAuthor
The failing tests are not related to these changes from what I can tell. |
juliusknorrforce-pushed
the
fix/deduplicate-templates
branch
2 times, most recently
from
December 3, 2025 09:25
af17860 to
b5fc422Compareelzodyforce-pushed
the
fix/deduplicate-templates
branch
from
December 9, 2025 18:57
b5fc422 to
70f0a52Comparemiaulalala
approved these changes
Dec 9, 2025
miaulalala
approved these changes
Dec 9, 2025
Uh oh!
There was an error while loading. Please reload this page.
elzodyforce-pushed
the
fix/deduplicate-templates
branch
from
December 9, 2025 20:14
70f0a52 to
d37f53cCompareCarlSchwan
approved these changes
Dec 10, 2025
Signed-off-by: Elizabeth Danzberger <elizabeth@elzody.dev>
elzodyforce-pushed
the
fix/deduplicate-templates
branch
from
December 10, 2025 21:06
d37f53c to
3a89c18CompareUh oh!
There was an error while loading. Please reload this page.
elzody
commented
Dec 11, 2025
ContributorAuthor
/backport to stable32 please |
elzody
commented
Dec 12, 2025
ContributorAuthor
/backport to stable31 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR de-duplicates provider templates. This will prevent the same global template from showing up twice in the template picker, as you can see in the screenshots. The reason this happens is because apps can provide the same template for several MIME types and there does not seem to be a way for an app to de-duplicate them itself. It is given one MIME type at a time when called by the server, so it is just expected to return the matching templates for that type and cannot know whether a given template has already been returned.
Screenshots
Before
After
Checklist
3. to review, feature component)stable32)