Skip to content

[stable29] refactor(workflowengine): Check if class is correct - #56846

Merged
blizzz merged 1 commit into
stable29from
backport/56839/stable29
Dec 10, 2025
Merged

[stable29] refactor(workflowengine): Check if class is correct#56846
blizzz merged 1 commit into
stable29from
backport/56839/stable29

Conversation

@backportbot

Copy link
Copy Markdown

Backport of PR #56839

@backportbotbackportbotBot added the 3. to review Waiting for reviews label Dec 4, 2025
@backportbotbackportbotBot self-assigned this Dec 4, 2025
@CarlSchwanCarlSchwan changed the title [stable29] [stable31] refactor(workflowengine): Check if class is correct[stable29] refactor(workflowengine): Check if class is correctDec 4, 2025
Comment threadapps/workflowengine/lib/Manager.php Dismissed
Comment threadapps/workflowengine/lib/Manager.php Dismissed
Comment threadapps/workflowengine/lib/Manager.php
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
@CarlSchwan
CarlSchwanforce-pushed the backport/56839/stable29 branch from 99854f1 to c6c03eeCompareDecember 9, 2025 09:35

protected function validateEvents(string $entity, array $events, IOperation $operation) {
/** @psalm-suppress TaintedCallable newInstance is not called */
$reflection = new \ReflectionClass($entity);

Check notice

Code scanning / Psalm

ArgumentTypeCoercion Note

Argument 1 of ReflectionClass::__construct expects class-string|object|trait-string, but parent type string provided
Comment threadapps/workflowengine/lib/Manager.php Dismissed
@blizzz
blizzz merged commit cde64a3 into stable29Dec 10, 2025
193 of 200 checks passed
@blizzz
blizzz deleted the backport/56839/stable29 branch December 10, 2025 18:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ChristophWurst@salmart-dev@CarlSchwan@github-advanced-security@blizzz