Skip to content

fix(css): correct boundaries of breaking points - #57010

Merged
susnux merged 2 commits into
masterfrom
fix/breaking-points
Dec 12, 2025
Merged

fix(css): correct boundaries of breaking points#57010
susnux merged 2 commits into
masterfrom
fix/breaking-points

Conversation

@susnux

@susnuxsusnux commented Dec 11, 2025

Copy link
Copy Markdown
Contributor

Summary

We mixed the logic of breaking points (when to break), this makes it consistent:
Mobile breaking point is 1024px, so it is applied to width < 1024 and starting with 1024 its "normal".

So we consistently have:
width < 512px: small mobile
512 <= width < 1024px: mobile
width >= 1024px: normal

Checklist

We mixed the logic of breaking points (when to break),
this makes it consistent:
Mobile breaking point is 1024px, so it is applied to width < 1024 and starting with 1024 its "normal".
So we consistently have:
width < 512px: small mobile
512 <= width < 1024px: mobile
width >= 1024px: normal
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnuxsusnux added this to the Nextcloud 33 milestone Dec 11, 2025
@susnuxsusnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Dec 11, 2025
@susnux
susnux marked this pull request as ready for review December 11, 2025 13:33
@susnux
susnux requested a review from a team as a code ownerDecember 11, 2025 13:33
@susnux
susnux requested review from nfebe, sorbaugh and szaimen and removed request for a teamDecember 11, 2025 13:33
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@susnux
susnux merged commit 0fe7875 into masterDec 12, 2025
135 of 141 checks passed
@susnux
susnux deleted the fix/breaking-points branch December 12, 2025 20:38
@solracsf

Copy link
Copy Markdown
Member

/backport a95d781 to stable32

1 similar comment
@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport a95d781 to stable32

@susnux

Copy link
Copy Markdown
ContributorAuthor

/backport a95d781 to stable31

@mijutu

Copy link
Copy Markdown

Is this fix supposed to work now? I just upgraded to 33.0.3 and I'm still having side bar over file names.
Screenshot of side bar covering file names in NC 33.0.3
The screenshot is from a new profile in Firefox that was just created and was never used with any other nextcloud version.

I didn't try with a new nextcloud instance.

@susnux

Copy link
Copy Markdown
ContributorAuthor

Is this fix supposed to work now? I just upgraded to 33.0.3 and I'm still having side bar over file names.

Yes it is fixed. The sidebar by design overflows the content if the screen width is < 1024px

@mijutu

Copy link
Copy Markdown

But I'm not seeing any difference to the situation before the fix.
If browser window is narrow, then file names are visible, like before.
If browser window is wide, then file names are visible, like before.
If browser windows is 1024 pixels wide, then file names are covered by the side bar, like before.

Compare my first screenshot with these two:

nc-narrownc-wide

@susnux

Copy link
Copy Markdown
ContributorAuthor

But I'm not seeing any difference to the situation before the fix.

Its only about the exact size of 1024px, there the behavior was wrong.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugdesignDesign, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: File names are covered by side bar if browser window is 1024 pixels wide

5 participants

@susnux@solracsf@mijutu@artonge@CarlSchwan