Uh oh!
There was an error while loading. Please reload this page.
fix(dav): catch NotFound exception in UploadHome::childExists() - #57096
Merged
Conversation
Signed-off-by: Josh <josh.t.richards@gmail.com>
joshtrichards
requested review from
Altahrim, CarlSchwan, icewind1991, provokateurin and salmart-dev
and removed request for
a teamDecember 15, 2025 16:01
joshtrichards
commented
Dec 15, 2025
MemberAuthor
/backport to stable32 |
joshtrichards
commented
Dec 15, 2025
MemberAuthor
/backport to stable31 |
provokateurin
approved these changes
Dec 15, 2025
provokateurin
enabled auto-merge
December 15, 2025 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The method never returns
falsefor non-existence - it either returnstrueor throws (passes on) an exception.This doesn't match the API contract for getChild().
The null check was meaningless since exceptions are thrown before null can be returned.
Discovered while implementing unit tests.
TODO
Checklist
3. to review, feature component)stable32)