Skip to content

fix(lib): include headers from OC\Template\Template as well in produced HTML - #57133

Merged
come-nc merged 1 commit into
masterfrom
fix-template-headers-injection
Dec 18, 2025
Merged

fix(lib): include headers from OC\Template\Template as well in produced HTML#57133
come-nc merged 1 commit into
masterfrom
fix-template-headers-injection

Conversation

@tcitworld

@tcitworldtcitworld commented Dec 16, 2025

Copy link
Copy Markdown
Member

Otherwise we only take those added through deprecated method OC_Util::addHeader, not those of OC\Template\Template::addHeader, which does nothing.

Too complicated to add tests unfortunately.

Checklist

@tcitworld
fix(lib): include headers from OC\Template\Template as well in produc…
8482302
…ed HTML
Otherwise we only take those added through deprecated method C_Util::addHeader, not those of
OC\Template\Template::addHeader, which does nothing
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworldtcitworld added this to the Nextcloud 33 milestone Dec 16, 2025
@tcitworld
tcitworld requested a review from a team as a code ownerDecember 16, 2025 22:03
@tcitworld
tcitworld requested review from ArtificialOwl, CarlSchwan and icewind1991 and removed request for a teamDecember 16, 2025 22:03
@come-nc
come-nc merged commit 9b12277 into masterDec 18, 2025
204 of 210 checks passed
@come-nc
come-nc deleted the fix-template-headers-injection branch December 18, 2025 10:59
@come-nc

come-nc commented Dec 18, 2025

Copy link
Copy Markdown
Contributor

/backport to stable32

@backportbotbackportbotBot mentioned this pull request Dec 18, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@solracsfsolracsfsolracsf approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsfeature: templates

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

4 participants

@tcitworld@come-nc@solracsf@CarlSchwan