Uh oh!
There was an error while loading. Please reload this page.
fix(ocm): fully disable signed request on config - #57156
Merged
Merged
Conversation
ArtificialOwl
requested review from
Altahrim, CarlSchwan, come-nc and salmart-dev
and removed request for
a teamDecember 17, 2025 19:54
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
ArtificialOwlforce-pushed
the
fix/noid/ocm-fully-disable-signed-request
branch
from
December 17, 2025 19:56
186335c to
4b68489CompareArtificialOwl
commented
Dec 18, 2025
MemberAuthor
/backport to stable32 |
ArtificialOwl
commented
Dec 18, 2025
MemberAuthor
/backport to stable31 |
Altahrim
approved these changes
Dec 18, 2025
AndyScherzinger
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue that disabling signed request will fail on already known remote key pairs.
This fix fully ignore the signed request feature once
core/ocm_signed_request_disabledis set to true