Skip to content

fix(files): properly handle currently active node and files action hotkeys - #57352

Merged
susnux merged 5 commits into
masterfrom
fix/active-files
Jan 16, 2026
Merged

fix(files): properly handle currently active node and files action hotkeys#57352
susnux merged 5 commits into
masterfrom
fix/active-files

Conversation

@susnux

@susnuxsusnux commented Jan 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  1. properly handle the active node also when navigating using keyboard
  2. register hotkeys setup in the files actions

Checklist

@susnuxsusnux added this to the Nextcloud 33 milestone Jan 5, 2026
@susnux
susnux requested review from a team and skjnldsv as code ownersJanuary 5, 2026 19:46
@susnuxsusnux added bug 3. to review Waiting for reviews labels Jan 5, 2026
@susnux
susnux requested review from sorbaugh and szaimen and removed request for a teamJanuary 5, 2026 19:46
@susnux
susnux requested review from CarlSchwan and nfebeJanuary 5, 2026 19:46
szaimen
szaimen approved these changes Jan 6, 2026
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux

susnux commented Jan 7, 2026

Copy link
Copy Markdown
ContributorAuthor

/compile

This was referenced Jan 7, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jan 14, 2026
Merged
@susnux
susnuxforce-pushed the fix/active-files branch 2 times, most recently from a95a51a to ea80589CompareJanuary 16, 2026 14:42
@susnux
fix(files): properly handle currently active node
03ffa39
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
fix(files): properly register file action hotkeys
b135e36
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
refactor(systemtags): properly register hotkey in the files app
24b3059
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
test: move integration testing of hotkeys to Cypress
b63aca7
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: compile assets
5597718
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux merged commit 60a4369 into masterJan 16, 2026
168 of 176 checks passed
@susnux
susnux deleted the fix/active-files branch January 16, 2026 19:47
@nextcloud-botnextcloud-bot mentioned this pull request Jan 20, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@szaimenszaimenszaimen approved these changes
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-frontend
@nfebenfebeAwaiting requested review from nfebe
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: files

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux@AndyScherzinger@szaimen