Skip to content

fix(psalm): Fix static analysis issues in apps/*/tests - #57404

Merged
Altahrim merged 1 commit into
masterfrom
carl/fix-psalm-tests1
Jan 16, 2026
Merged

fix(psalm): Fix static analysis issues in apps/*/tests#57404
Altahrim merged 1 commit into
masterfrom
carl/fix-psalm-tests1

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Jan 7, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Summary

There are still 1200 more to fix before we can enable static analysis for the tests, but at least this prepare the ground for doing that by fixing some repetitive issues.

TODO

  • ...

Checklist

@CarlSchwanCarlSchwan added this to the Nextcloud 33 milestone Jan 7, 2026
@CarlSchwanCarlSchwan self-assigned this Jan 7, 2026
@CarlSchwanCarlSchwan added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 tests Related to tests labels Jan 7, 2026
@CarlSchwan
CarlSchwanforce-pushed the carl/fix-psalm-tests1 branch from 159a46c to 5184975CompareJanuary 7, 2026 14:00
@CarlSchwan
CarlSchwan marked this pull request as ready for review January 8, 2026 15:41
@CarlSchwan
CarlSchwan requested review from artonge, leftybournes, provokateurin and sorbaugh and removed request for a teamJanuary 8, 2026 15:41
@nextcloud-botnextcloud-bot mentioned this pull request Jan 9, 2026
Merged
artonge
artonge approved these changes Jan 9, 2026
View reviewed changes
Comment threadapps/dav/tests/unit/CardDAV/Activity/BackendTest.php
Comment threadapps/files_external/lib/Controller/GlobalStoragesController.php
Comment threadapps/files_external/lib/Controller/StoragesController.php
@CarlSchwan
CarlSchwanforce-pushed the carl/fix-psalm-tests1 branch 2 times, most recently from eda9ae2 to 3ba2735CompareJanuary 12, 2026 09:38
@ChristophWurstChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 12, 2026
@nextcloud-botnextcloud-bot mentioned this pull request Jan 14, 2026
Merged
@CarlSchwan
fix(psalm): Fix static analysis issues in apps/*/tests
11cf69d
There are still 1200 more to fix before we can enable static analysis
for the tests.
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@Altahrim
Altahrim merged commit 0ff9de1 into masterJan 16, 2026
197 of 209 checks passed
@Altahrim
Altahrim deleted the carl/fix-psalm-tests1 branch January 16, 2026 13:09
@nextcloud-botnextcloud-bot mentioned this pull request Jan 20, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artongeartongeartonge approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@hamza221hamza221hamza221 approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessennickvergessen is a code owner
@blizzzblizzzAwaiting requested review from blizzzblizzz is a code owner
@miaulalalamiaulalalaAwaiting requested review from miaulalalamiaulalala is a code owner
@SebastianKrupinskiSebastianKrupinskiAwaiting requested review from SebastianKrupinskiSebastianKrupinski is a code owner
@tcitworldtcitworldAwaiting requested review from tcitworldtcitworld is a code owner
@kesselbkesselbAwaiting requested review from kesselbkesselb is a code owner
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@provokateurinprovokateurinAwaiting requested review from provokateurinprovokateurin is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@CarlSchwanCarlSchwan

Labels

4. to releaseReady to be released and/or waiting for tests to finishtechnical debt🧱 🤔🚀testsRelated to tests

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan@ChristophWurst@artonge@hamza221@Altahrim