Skip to content

feat(signed-request): moving out of unstable - #57449

Merged
Altahrim merged 1 commit into
masterfrom
feat/unstable/moving-out-of-unstable-signature
Jan 12, 2026
Merged

feat(signed-request): moving out of unstable#57449
Altahrim merged 1 commit into
masterfrom
feat/unstable/moving-out-of-unstable-signature

Conversation

@ArtificialOwl

@ArtificialOwlArtificialOwl commented Jan 9, 2026

Copy link
Copy Markdown
Member

no changes in code, only moving out of unstable:

  • copying unstable files from lib/unstable/Security/Signature/ to lib/public/Security/Signature,
  • copying lib/unstable/Federation/ISignedCloudFederationProvider to lib/public/Federation/,
  • switching from @experimental 31.0.0 to @deprecated 33.0.0 in deprecated/unstable files,
  • switching from @experimental 31.0.0 to @since 33.0.0 in fresh public files copy,
  • switching all import from NCU/ namespace to its equivalent to OCP/ namespace,
  • adding Attributes to fresh public files,

@ArtificialOwl

ArtificialOwl commented Jan 9, 2026

Copy link
Copy Markdown
MemberAuthor

diff between files in unstable/ and those in public/:

9,11c9
< namespace NCU\Federation;
< < use OCP\Federation\ICloudFederationProvider;
---
> namespace OCP\Federation;
18,19c16
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Federation\ISignedCloudFederationProvider}
---
> * @since 33.0.0
30,31c27
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Federation\ISignedCloudFederationProvider}
---
> * @since 31.0.0
diff -r lib/unstable/Security/Signature/Enum/DigestAlgorithm.php lib/public/Security/Signature/Enum/DigestAlgorithm.php
9c9,11
< namespace NCU\Security\Signature\Enum;
---
> namespace OCP\Security\Signature\Enum;
> > use OCP\AppFramework\Attribute\Consumable;
14,15c16
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Enum\DigestAlgorithm}
---
> * @since 33.0.0
16a18
> #[Consumable(since: '33.0.0')]
18,21c20
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
23,26c22
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
33,35c29
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Enum\DigestAlgorithm}
< * @psalm-suppress DeprecatedClass
---
> * @since 33.0.0
diff -r lib/unstable/Security/Signature/Enum/SignatoryStatus.php lib/public/Security/Signature/Enum/SignatoryStatus.php
9c9,11
< namespace NCU\Security\Signature\Enum;
---
> namespace OCP\Security\Signature\Enum;
> > use OCP\AppFramework\Attribute\Consumable;
17,18c19
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Enum\SignatoryStatus}
---
> * @since 33.0.0
19a21
> #[Consumable(since: '33.0.0')]
21,24c23
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
26,29c25
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
diff -r lib/unstable/Security/Signature/Enum/SignatoryType.php lib/public/Security/Signature/Enum/SignatoryType.php
9c9,11
< namespace NCU\Security\Signature\Enum;
---
> namespace OCP\Security\Signature\Enum;
> > use OCP\AppFramework\Attribute\Consumable;
19,20c21
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Enum\SignatoryType}
---
> * @since 33.0.0
21a23
> #[Consumable(since: '33.0.0')]
23,26c25
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
28,31c27
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
33,36c29
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
38,41c31
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
diff -r lib/unstable/Security/Signature/Enum/SignatureAlgorithm.php lib/public/Security/Signature/Enum/SignatureAlgorithm.php
9c9,11
< namespace NCU\Security\Signature\Enum;
---
> namespace OCP\Security\Signature\Enum;
> > use OCP\AppFramework\Attribute\Consumable;
14,15c16
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Enum\SignatureAlgorithm}
---
> * @since 33.0.0
16a18
> #[Consumable(since: '33.0.0')]
18,21c20
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
23,26c22
< /**
< * @experimental 31.0.0
< * @deprecated 33.0.0
< */
---
> /** @since 33.0.0 */
diff -r lib/unstable/Security/Signature/Exceptions/IdentityNotFoundException.php lib/public/Security/Signature/Exceptions/IdentityNotFoundException.php
9c9,11
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
> > use OCP\AppFramework\Attribute\Throwable;
12,13c14
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\IdentityNotFoundException}
---
> * @since 33.0.0
14a16
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/Exceptions/IncomingRequestException.php lib/public/Security/Signature/Exceptions/IncomingRequestException.php
9c9,11
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
> > use OCP\AppFramework\Attribute\Throwable;
12,13c14
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\IncomingRequestException}
---
> * @since 33.0.0
14a16
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/Exceptions/InvalidKeyOriginException.php lib/public/Security/Signature/Exceptions/InvalidKeyOriginException.php
9c9,11
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
> > use OCP\AppFramework\Attribute\Throwable;
12,13c14
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\InvalidKeyOriginException}
---
> * @since 33.0.0
14a16
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/Exceptions/InvalidSignatureException.php lib/public/Security/Signature/Exceptions/InvalidSignatureException.php
9c9,11
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
> > use OCP\AppFramework\Attribute\Throwable;
12,13c14
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\InvalidSignatureException}
---
> * @since 33.0.0
14a16
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/Exceptions/SignatoryConflictException.php lib/public/Security/Signature/Exceptions/SignatoryConflictException.php
9c9,11
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
> > use OCP\AppFramework\Attribute\Throwable;
12,13c14
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\SignatoryConflictException}
---
> * @since 33.0.0
14a16
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/Exceptions/SignatoryException.php lib/public/Security/Signature/Exceptions/SignatoryException.php
9c9,11
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
> > use OCP\AppFramework\Attribute\Throwable;
12,13c14
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\SignatoryException}
---
> * @since 33.0.0
14a16
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/Exceptions/SignatoryNotFoundException.php lib/public/Security/Signature/Exceptions/SignatoryNotFoundException.php
9c9,11
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
> > use OCP\AppFramework\Attribute\Throwable;
12,13c14
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\SignatoryNotFoundException}
---
> * @since 33.0.0
14a16
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/Exceptions/SignatureElementNotFoundException.php lib/public/Security/Signature/Exceptions/SignatureElementNotFoundException.php
9c9,11
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
> > use OCP\AppFramework\Attribute\Throwable;
12,13c14
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\SignatureElementNotFoundException}
---
> * @since 33.0.0
14a16
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/Exceptions/SignatureException.php lib/public/Security/Signature/Exceptions/SignatureException.php
9c9
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
11a12
> use OCP\AppFramework\Attribute\Throwable;
14,15c15
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\SignatureException}
---
> * @since 33.0.0
16a17
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/Exceptions/SignatureNotFoundException.php lib/public/Security/Signature/Exceptions/SignatureNotFoundException.php
9c9,11
< namespace NCU\Security\Signature\Exceptions;
---
> namespace OCP\Security\Signature\Exceptions;
> > use OCP\AppFramework\Attribute\Throwable;
12,13c14
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Exceptions\SignatureNotFoundException}
---
> * @since 33.0.0
14a16
> #[Throwable(since: '33.0.0')]
diff -r lib/unstable/Security/Signature/IIncomingSignedRequest.php lib/public/Security/Signature/IIncomingSignedRequest.php
9c9
< namespace NCU\Security\Signature;
---
> namespace OCP\Security\Signature;
11,13c11
< use NCU\Security\Signature\Exceptions\SignatoryNotFoundException;
< use NCU\Security\Signature\Exceptions\SignatureElementNotFoundException;
< use NCU\Security\Signature\Exceptions\SignatureException;
---
> use OCP\AppFramework\Attribute\Consumable;
14a13,15
> use OCP\Security\Signature\Exceptions\SignatoryNotFoundException;
> use OCP\Security\Signature\Exceptions\SignatureElementNotFoundException;
> use OCP\Security\Signature\Exceptions\SignatureException;
28,29c29
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IIncomingSignedRequest}
---
> * @since 33.0.0
30a31
> #[Consumable(since: '33.0.0')]
36,37c37
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IIncomingSignedRequest}
---
> * @since 33.0.0
46,47c46
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IIncomingSignedRequest}
---
> * @since 33.0.0
57,58c56
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IIncomingSignedRequest}
---
> * @since 33.0.0
67,68c65
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IIncomingSignedRequest}
---
> * @since 33.0.0
diff -r lib/unstable/Security/Signature/IOutgoingSignedRequest.php lib/public/Security/Signature/IOutgoingSignedRequest.php
9c9
< namespace NCU\Security\Signature;
---
> namespace OCP\Security\Signature;
11,13c11,14
< use NCU\Security\Signature\Enum\SignatureAlgorithm;
< use NCU\Security\Signature\Exceptions\SignatoryException;
< use NCU\Security\Signature\Exceptions\SignatoryNotFoundException;
---
> use OCP\AppFramework\Attribute\Consumable;
> use OCP\Security\Signature\Enum\SignatureAlgorithm;
> use OCP\Security\Signature\Exceptions\SignatoryException;
> use OCP\Security\Signature\Exceptions\SignatoryNotFoundException;
26,27c27
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
28a29
> #[Consumable(since: '33.0.0')]
35,36c36
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
46,47c46
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
58,59c57
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
67,68c65
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
78,79c75
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
87,88c83
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
98,99c93
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
107,108c101
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
118,119c111
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\IOutgoingSignedRequest}
---
> * @since 33.0.0
diff -r lib/unstable/Security/Signature/ISignatoryManager.php lib/public/Security/Signature/ISignatoryManager.php
9c9
< namespace NCU\Security\Signature;
---
> namespace OCP\Security\Signature;
11c11,12
< use NCU\Security\Signature\Model\Signatory;
---
> use OCP\AppFramework\Attribute\Consumable;
> use OCP\Security\Signature\Model\Signatory;
21,22c22
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatoryManager}
---
> * @since 33.0.0
23a24
> #[Consumable(since: '33.0.0')]
32,33c33
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatoryManager}
---
> * @since 33.0.0
49,50c49
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatoryManager}
---
> * @since 33.0.0
60,62c59
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatoryManager}
< * @psalm-suppress DeprecatedClass
---
> * @since 33.0.0
75,77c72
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatoryManager}
< * @psalm-suppress DeprecatedClass
---
> * @since 33.0.0
diff -r lib/unstable/Security/Signature/ISignatureManager.php lib/public/Security/Signature/ISignatureManager.php
9c9
< namespace NCU\Security\Signature;
---
> namespace OCP\Security\Signature;
11,16c11,17
< use NCU\Security\Signature\Exceptions\IdentityNotFoundException;
< use NCU\Security\Signature\Exceptions\IncomingRequestException;
< use NCU\Security\Signature\Exceptions\SignatoryNotFoundException;
< use NCU\Security\Signature\Exceptions\SignatureException;
< use NCU\Security\Signature\Exceptions\SignatureNotFoundException;
< use NCU\Security\Signature\Model\Signatory;
---
> use OCP\AppFramework\Attribute\Consumable;
> use OCP\Security\Signature\Exceptions\IdentityNotFoundException;
> use OCP\Security\Signature\Exceptions\IncomingRequestException;
> use OCP\Security\Signature\Exceptions\SignatoryNotFoundException;
> use OCP\Security\Signature\Exceptions\SignatureException;
> use OCP\Security\Signature\Exceptions\SignatureNotFoundException;
> use OCP\Security\Signature\Model\Signatory;
54,55c55
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatureManager}
---
> * @since 33.0.0
56a57
> #[Consumable(since: '33.0.0')]
72,74c73
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatureManager}
< * @psalm-suppress DeprecatedClass
---
> * @since 33.0.0
88,90c87
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatureManager}
< * @psalm-suppress DeprecatedClass
---
> * @since 33.0.0
104,106c101
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatureManager}
< * @psalm-suppress DeprecatedClass
---
> * @since 33.0.0
118,120c113
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatureManager}
< * @psalm-suppress DeprecatedClass
---
> * @since 33.0.0
131,132c124
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatureManager}
---
> * @since 33.0.0
143,144c135
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignatureManager}
---
> * @since 33.0.0
diff -r lib/unstable/Security/Signature/ISignedRequest.php lib/public/Security/Signature/ISignedRequest.php
9c9
< namespace NCU\Security\Signature;
---
> namespace OCP\Security\Signature;
11,14c11,15
< use NCU\Security\Signature\Enum\DigestAlgorithm;
< use NCU\Security\Signature\Exceptions\SignatoryNotFoundException;
< use NCU\Security\Signature\Exceptions\SignatureElementNotFoundException;
< use NCU\Security\Signature\Model\Signatory;
---
> use OCP\AppFramework\Attribute\Consumable;
> use OCP\Security\Signature\Enum\DigestAlgorithm;
> use OCP\Security\Signature\Exceptions\SignatoryNotFoundException;
> use OCP\Security\Signature\Exceptions\SignatureElementNotFoundException;
> use OCP\Security\Signature\Model\Signatory;
26,27c27
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
28a29
> #[Consumable(since: '33.0.0')]
34,35c35
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
43,45c43
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
< * @psalm-suppress DeprecatedClass
---
> * @since 33.0.0
53,54c51
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
64,65c61
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
73,74c69
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
83,84c78
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
92,93c86
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
101,102c94
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
111,112c103
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
121,122c112
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
130,131c120
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\ISignedRequest}
---
> * @since 33.0.0
diff -r lib/unstable/Security/Signature/Model/Signatory.php lib/public/Security/Signature/Model/Signatory.php
9c9
< namespace NCU\Security\Signature\Model;
---
> namespace OCP\Security\Signature\Model;
12,14c12
< use NCU\Security\Signature\Enum\SignatoryStatus;
< use NCU\Security\Signature\Enum\SignatoryType;
< use NCU\Security\Signature\Exceptions\IdentityNotFoundException;
---
> use OCP\AppFramework\Attribute\Consumable;
15a14,16
> use OCP\Security\Signature\Enum\SignatoryStatus;
> use OCP\Security\Signature\Enum\SignatoryType;
> use OCP\Security\Signature\Exceptions\IdentityNotFoundException;
25,26c26
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
51a52
> #[Consumable(since: '33.0.0')]
69,70c70
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
91,92c91
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
120,121c119
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
129,130c127
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
138,139c135
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
147,148c143
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
155,156c150
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
167,168c161
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
177,178c170
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0
194,195c186
< * @experimental 31.0.0
< * @deprecated 33.0.0 use {@see \OCP\Security\Signature\Model\Signatory}
---
> * @since 33.0.0

@ArtificialOwl
ArtificialOwlforce-pushed the feat/unstable/moving-out-of-unstable-signature branch 2 times, most recently from d311e8a to f2e1b34CompareJanuary 9, 2026 15:27
@ArtificialOwlArtificialOwl added this to the Nextcloud 33 milestone Jan 9, 2026
@ArtificialOwlArtificialOwl added the 3. to review Waiting for reviews label Jan 9, 2026
@ArtificialOwlArtificialOwl mentioned this pull request Jan 9, 2026
Merged
@ArtificialOwl
ArtificialOwl marked this pull request as ready for review January 9, 2026 17:29
@ArtificialOwl
ArtificialOwl requested review from Altahrim, leftybournes, nfebe and yemkareems and removed request for a teamJanuary 9, 2026 17:29
@ArtificialOwl
feat(signed-request): moving out of unstable
327d691
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwlforce-pushed the feat/unstable/moving-out-of-unstable-signature branch from f2e1b34 to 327d691CompareJanuary 9, 2026 21:16
@Altahrim
Altahrim merged commit e0e5cdf into masterJan 12, 2026
222 of 233 checks passed
@Altahrim
Altahrim deleted the feat/unstable/moving-out-of-unstable-signature branch January 12, 2026 08:39
@susnuxsusnux added the pending documentation This pull request needs an associated documentation update label Jan 28, 2026
@susnux

susnux commented Jan 28, 2026

Copy link
Copy Markdown
Contributor

New public API (interfaces, classes, traits) in OCP need to be mentioned here:
https://github.com/nextcloud/documentation/blob/1a0415c8bf1541e90ae0b4da487a362a51a1cfe2/developer_manual/app_publishing_maintenance/app_upgrade_guide/upgrade_to_33.rst?plain=1#L184

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@icewind1991icewind1991icewind1991 approved these changes
@come-nccome-nccome-nc approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessennickvergessen is a code owner
@AltahrimAltahrimAwaiting requested review from AltahrimAltahrim is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@yemkareemsyemkareemsAwaiting requested review from yemkareemsyemkareems is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewspending documentationThis pull request needs an associated documentation update

Projects

None yet

Milestone

Nextcloud 33

Development

Successfully merging this pull request may close these issues.

6 participants

@ArtificialOwl@susnux@icewind1991@come-nc@Altahrim@tobiasKaminsky