Skip to content

refactor: drop moment from new bundles - #57503

Merged
susnux merged 2 commits into
masterfrom
chore/drop-moment
Jan 14, 2026
Merged

refactor: drop moment from new bundles#57503
susnux merged 2 commits into
masterfrom
chore/drop-moment

Conversation

@susnux

@susnuxsusnux commented Jan 12, 2026

Copy link
Copy Markdown
Contributor

On the Vue 3 side lets remove the dependency on Moment as this is a pretty huge dependency. Instead use something tiny like dayjs for date computation (end of week / end of day) and use plain Intl API for formatting.

This reduces the bundle size by 9%.

Checklist

@susnuxsusnux added this to the Nextcloud 33 milestone Jan 12, 2026
@susnux
susnux requested a review from ShGKmeJanuary 12, 2026 20:38
@susnux
susnux requested review from a team as code ownersJanuary 12, 2026 20:38
@susnuxsusnux added 3. to review Waiting for reviews dependencies labels Jan 12, 2026
@susnux
susnux requested review from nfebe and szaimen and removed request for a teamJanuary 12, 2026 20:38
@susnuxsusnux added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Jan 12, 2026
@susnux
susnux requested review from sorbaugh and removed request for a teamJanuary 12, 2026 20:38

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Comment threadapps/user_status/src/services/clearAtService.js Outdated
@susnux
susnux requested a review from ShGKmeJanuary 13, 2026 10:15
@nextcloud-botnextcloud-bot mentioned this pull request Jan 12, 2026
On the Vue 3 side lets remove the dependency on Moment as this is a
pretty huge dependency. Instead use plain Intl API for formatting.
This reduces the bundle size by ~1.5MiB.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux merged commit 22ebf79 into masterJan 14, 2026
146 of 150 checks passed
@susnux
susnux deleted the chore/drop-moment branch January 14, 2026 11:33
@nextcloud-botnextcloud-bot mentioned this pull request Jan 14, 2026
asavageiv added a commit to asavageiv/tasks that referenced this pull request Jan 19, 2026
Following nextcloud/server#57503, this saves about 15%
of the zipped bundle size for Tasks.
Signed-off-by: Alan Savage <3028205+asavageiv@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsdependenciesperformance 🚀♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@CarlSchwan@ShGKme@szaimen