Uh oh!
There was an error while loading. Please reload this page.
debt(files_sharing): Unify getSharedWithByPath and getSharedWith - #57552
Merged
Conversation
artonge
requested review from
Altahrim, CarlSchwan, salmart-dev and yemkareems
and removed request for
a teamJanuary 14, 2026 17:23
artongeforce-pushed
the
artonge/debt/files_sharing_unify_methods
branch
from
January 14, 2026 17:26
0b251f6 to
99cc26dCompareartongeforce-pushed
the
feature/54562/files-sharing-authoritative
branch
4 times, most recently
from
January 15, 2026 08:29
55ae98c to
e278f3eCompareartongeforce-pushed
the
artonge/debt/files_sharing_unify_methods
branch
from
January 15, 2026 08:48
99cc26d to
31110cbCompareartonge
changed the base branch from
feature/54562/files-sharing-authoritative
to
masterJanuary 15, 2026 08:48
artongeforce-pushed
the
artonge/debt/files_sharing_unify_methods
branch
2 times, most recently
from
January 15, 2026 09:08
8d2157b to
4695508CompareFollow-up of #57285 This ensure that the behavior is the same and reduce code duplication. Salvatore's version seems to be more optimized, but I prefer those change to be done separately and for both methods. Signed-off-by: Louis Chmn <louis@chmn.me>
artongeforce-pushed
the
artonge/debt/files_sharing_unify_methods
branch
from
January 15, 2026 09:23
4695508 to
bba8e90CompareCarlSchwan
approved these changes
Jan 15, 2026
artonge
enabled auto-merge
January 15, 2026 13:02
Altahrim
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up of #57285
This ensure that the behavior is the same and reduce code duplication.
Salvatore's version seems to be more optimized, but I prefer those change to be done separately and for both methods.