Uh oh!
There was an error while loading. Please reload this page.
fix: clearify meaning of getMountsForPath arguments - #57553
Merged
Conversation
icewind1991
requested review from
ArtificialOwl, come-nc, salmart-dev and yemkareems
and removed request for
a teamJanuary 14, 2026 17:39
7 tasks
icewind1991force-pushed
the
getMountsForPath-args
branch
from
January 14, 2026 17:56
018cfb6 to
c55de7eCompareprovokateurin
approved these changes
Jan 14, 2026
Altahrim
approved these changes
Jan 15, 2026
artonge
reviewed
Jan 15, 2026
Uh oh!
There was an error while loading. Please reload this page.
icewind1991force-pushed
the
getMountsForPath-args
branch
2 times, most recently
from
January 15, 2026 10:25
ba3c08b to
ecfb76fCompareSigned-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991force-pushed
the
getMountsForPath-args
branch
from
January 15, 2026 10:32
ecfb76f to
53b160cCompareUh oh!
There was an error while loading. Please reload this page.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The meaning of
$pathwas repeatedly causing confusion.Further improvements to variable naming and documentation is more than welcome.