Skip to content

chore(settings): remove dead legacy code - #57565

Merged
susnux merged 2 commits into
masterfrom
chore/remove-dead-code
Jan 15, 2026
Merged

chore(settings): remove dead legacy code#57565
susnux merged 2 commits into
masterfrom
chore/remove-dead-code

Conversation

@susnux

@susnuxsusnux commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Summary

The security_password was last used in the personal setting security section, but already migrated to vue.
So it can be safely removed.

The styles can also be removed by moving the required ones directly to the Vue component.

Checklist

@susnuxsusnux added this to the Nextcloud 33 milestone Jan 15, 2026
@susnux
susnux requested a review from a team as a code ownerJanuary 15, 2026 10:18
@susnux
susnux removed the request for review from a teamJanuary 15, 2026 10:18
@susnuxsusnux added the 3. to review Waiting for reviews label Jan 15, 2026
@susnuxsusnux added feature: settings ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jan 15, 2026
@susnuxsusnux mentioned this pull request Jan 15, 2026
36 tasks

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

The `security_password` was last used in the personal setting security
section, but already migrated to vue.
So it can be safely removed.
The styles can also be removed by moving the required ones directly to
the Vue component.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnuxforce-pushed the chore/remove-dead-code branch from 7ef86ab to ddff2cbCompareJanuary 15, 2026 15:20
@susnux
susnux merged commit 13718c4 into masterJan 15, 2026
145 of 153 checks passed
@susnux
susnux deleted the chore/remove-dead-code branch January 15, 2026 22:04
@nextcloud-botnextcloud-bot mentioned this pull request Jan 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsfeature: settings♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@susnux@CarlSchwan@szaimen