Skip to content

fix(files_sharing): Fix BeforeZipCreatedListener path handling - #57573

Merged
come-nc merged 3 commits into
masterfrom
fix/fix-beforezipcreatedlistener
Jan 20, 2026
Merged

fix(files_sharing): Fix BeforeZipCreatedListener path handling#57573
come-nc merged 3 commits into
masterfrom
fix/fix-beforezipcreatedlistener

Conversation

@come-nc

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Lighter alternative to #57335

Checklist

Path of directory is relative to root folder, not user folder.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nccome-nc added this to the Nextcloud 33 milestone Jan 15, 2026
@come-nc
come-nc requested a review from susnuxJanuary 15, 2026 16:20
@come-nccome-nc self-assigned this Jan 15, 2026
@come-nc
come-nc requested a review from a team as a code ownerJanuary 15, 2026 16:20
@come-nccome-nc added the 3. to review Waiting for reviews label Jan 15, 2026
@come-nc
come-nc requested review from Altahrim, CarlSchwan, leftybournes and yemkareems and removed request for a teamJanuary 15, 2026 16:20
@nextcloud-botnextcloud-bot mentioned this pull request Jan 15, 2026
@Koc

Koc commented Jan 16, 2026

Copy link
Copy Markdown
Contributor

check also ConversionApiController::convert, we need add check here as well

This is clearly the original intent, the parameter name in ViewOnly is
$userFolder, and the similar event for single file download uses
paths relative to user folder as well.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-botnextcloud-bot mentioned this pull request Jan 20, 2026
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc
come-nc enabled auto-merge January 20, 2026 14:15
@come-nc
come-nc merged commit a467589 into masterJan 20, 2026
221 of 231 checks passed
@come-nc
come-nc deleted the fix/fix-beforezipcreatedlistener branch January 20, 2026 15:08
@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

@come-nc

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@come-nc@Koc@susnux@CarlSchwan