Uh oh!
There was an error while loading. Please reload this page.
feat(sharing): Make share permission in bundled edit configurable - #57741
Merged
AndyScherzinger merged 1 commit intoFeb 5, 2026
Merged
Conversation
nfebe
requested review from
come-nc and sorbaugh
and removed request for
a teamJanuary 22, 2026 17:27
nfebeforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
2 times, most recently
from
January 22, 2026 18:04
8f0083f to
2c1ee9cCompareAndyScherzinger
commented
Jan 25, 2026
Member
/backport to stable33 |
come-nc
requested changes
Jan 26, 2026
come-nc
left a comment
Contributor
There was a problem hiding this comment.
The setting shoud be in the application files_sharing, not in core.
nfebeforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
from
January 26, 2026 22:06
2c1ee9c to
2ace2b6Comparenfebeforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
2 times, most recently
from
January 26, 2026 22:39
bd1649c to
274dbb8Comparenfebeforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
3 times, most recently
from
January 29, 2026 08:45
949deb5 to
262cf8cComparecome-nc
reviewed
Jan 29, 2026
come-nc
left a comment
Contributor
There was a problem hiding this comment.
You pushed 3rdparty by mistake.
Also, is it expected that the new option is false by default? I thought the previous behaviour was to include it?
Uh oh!
There was an error while loading. Please reload this page.
nfebeforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
3 times, most recently
from
January 29, 2026 10:48
fd9f04b to
617c31fCompareprovokateurin
requested changes
Jan 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
come-nc
previously requested changes
Jan 29, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nfebeforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
2 times, most recently
from
January 29, 2026 14:19
7e9ef21 to
3ed65a8Compareprovokateurin
requested changes
Jan 29, 2026
provokateurin
left a comment
Member
There was a problem hiding this comment.
LGTM, just one small change please.
Uh oh!
There was an error while loading. Please reload this page.
nfebeforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
2 times, most recently
from
January 29, 2026 15:00
d1e35e9 to
79e1214CompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nfebeforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
from
January 29, 2026 15:05
79e1214 to
f729f27Compareprovokateurin
approved these changes
Jan 29, 2026
nfebeforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
from
January 30, 2026 10:31
f729f27 to
631f2efComparemarcoambrosini
removed their request for review
February 4, 2026 09:32
AndyScherzingerforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
from
February 4, 2026 22:24
631f2ef to
b6d612fComparesusnux
approved these changes
Feb 4, 2026
CarlSchwanforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
from
February 5, 2026 00:38
b6d612f to
fc7c32bCompareCarlSchwan
commented
Feb 5, 2026
Member
/compile amend / |
nextcloud-commandforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
from
February 5, 2026 00:46
fc7c32b to
a80ff72CompareAdd config option shareapi_bundle_reshare_with_edit to include reshare permission in "Allow editing" bundle. Default is true to maintain backward compatibility. Signed-off-by: nfebe <fenn25.fn@gmail.com> Signed-off-by: Carl Schwan <carlschwan@kde.org> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
AndyScherzingerforce-pushed
the
feat/configurable-share-permission-in-bundled
branch
from
February 5, 2026 06:36
a80ff72 to
b7dceb0CompareUh oh!
There was an error while loading. Please reload this page.
AndyScherzinger
deleted the
feat/configurable-share-permission-in-bundled
branch
February 5, 2026 09:09
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add config option
shareapi_include_share_in_editto include reshare permission in "Allow editing" bundle.