Skip to content

fix(openmetrics): fix label names and add test for them - #57764

Merged
Altahrim merged 1 commit into
masterfrom
fix/openmetrics_labels
Jan 25, 2026
Merged

fix(openmetrics): fix label names and add test for them#57764
Altahrim merged 1 commit into
masterfrom
fix/openmetrics_labels

Conversation

@Altahrim

@AltahrimAltahrim commented Jan 23, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

Enforce correct formatting for labels

label-name = label-name-initial-char *label-name-char
label-name-char = label-name-initial-char / DIGIT
label-name-initial-char = ALPHA / "_"

Checklist

@AltahrimAltahrim added this to the Nextcloud 34 milestone Jan 23, 2026
@AltahrimAltahrim self-assigned this Jan 23, 2026
@Altahrim
Altahrim requested a review from a team as a code ownerJanuary 23, 2026 16:15
@Altahrim
Altahrim requested review from ArtificialOwl, icewind1991, nfebe and salmart-dev and removed request for a teamJanuary 23, 2026 16:15
@AltahrimAltahrim added bug 3. to review Waiting for reviews labels Jan 23, 2026
CarlSchwan
CarlSchwan reviewed Jan 23, 2026
View reviewed changes
Comment threadtests/lib/OpenMetrics/Exporters/ExporterTestCase.php Outdated
@Altahrim
fix(openmetrics): fix label names and add test for them
481fe15
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
Altahrimforce-pushed the fix/openmetrics_labels branch from 0753717 to 481fe15CompareJanuary 24, 2026 14:54
@Altahrim
Altahrim enabled auto-merge January 25, 2026 15:54
SystemKeeper
SystemKeeper approved these changes Jan 25, 2026
View reviewed changes

@SystemKeeperSystemKeeper left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue.

@Altahrim
Altahrim merged commit 8af5e06 into masterJan 25, 2026
176 of 178 checks passed
@Altahrim
Altahrim deleted the fix/openmetrics_labels branch January 25, 2026 21:51
@Altahrim

Altahrim commented Jan 26, 2026

Copy link
Copy Markdown
CollaboratorAuthor

/backport to stable33 please

@backportbotbackportbotBot mentioned this pull request Jan 26, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Apr 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwanCarlSchwanCarlSchwan approved these changes
@SystemKeeperSystemKeeperSystemKeeper approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend

Assignees

@AltahrimAltahrim

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

3 participants

@Altahrim@SystemKeeper@CarlSchwan