Skip to content

fix(files_external): Respect explicit port configuration - #57793

Merged
sorbaugh merged 1 commit into
nextcloud:masterfrom
pac0san:patch-1
Feb 2, 2026
Merged

fix(files_external): Respect explicit port configuration#57793
sorbaugh merged 1 commit into
nextcloud:masterfrom
pac0san:patch-1

Conversation

@pac0san

@pac0sanpac0san commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

It allows the use of the alternative SFTP port defined in the GUI (external storage), instead of the default port (22).

  • Resolves: #

Summary

TODO

  • ...

Checklist

@pac0san
pac0san requested a review from a team as a code ownerJanuary 25, 2026 17:13
@pac0san
pac0san requested review from icewind1991, leftybournes, provokateurin and salmart-dev and removed request for a teamJanuary 25, 2026 17:13
provokateurin
provokateurin requested changes Jan 25, 2026
View reviewed changes
Comment threadapps/files_external/lib/Lib/Storage/SFTP.php Outdated
@provokateurin

provokateurin commented Feb 2, 2026

Copy link
Copy Markdown
Member

The port field will now take precedence over the port parsed from the host, but the old behavior is still there to avoid breaking changes.

@provokateurin

provokateurin commented Feb 2, 2026

Copy link
Copy Markdown
Member

/backport to stable33

@provokateurin

provokateurin commented Feb 2, 2026

Copy link
Copy Markdown
Member

/backport to stable32

@provokateurin

provokateurin commented Feb 2, 2026

Copy link
Copy Markdown
Member

/backport to stable31

@pac0san@provokateurin
fix(files_external): Respect explicit port configuration
e48f871
It allows the use of the alternative SFTP port defined in the GUI (external storage), instead of the default port (22).
Signed-off-by: pac0san <7056343+pac0san@users.noreply.github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
@provokateurinprovokateurin changed the title Update SFTP.phpfix(files_external): Respect explicit port configurationFeb 2, 2026
@provokateurinprovokateurin self-assigned this Feb 2, 2026
@AndyScherzingerAndyScherzinger added this to the Nextcloud 34 milestone Feb 2, 2026
@sorbaugh
sorbaugh merged commit e10805f into nextcloud:masterFeb 2, 2026
172 of 183 checks passed
@welcome

welcomeBot commented Feb 2, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

This was referenced Feb 2, 2026
Merged
Merged
Merged
@github-actions

github-actionsBot commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

This was referenced Feb 13, 2026
Closed
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Apr 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzingerAndyScherzingerAndyScherzinger approved these changes
@susnuxsusnuxsusnux approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@cristianscheidcristianscheidcristianscheid approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

@provokateurinprovokateurin

Labels

feedback-requested

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

6 participants

@pac0san@provokateurin@AndyScherzinger@susnux@cristianscheid@sorbaugh