Uh oh!
There was an error while loading. Please reload this page.
feat: make timezone service public - #58263
Open
miaulalala wants to merge 3 commits into
Open
Conversation
Signed-off-by: Anna Larch <anna@nextcloud.com>
miaulalala
requested review from
ChristophWurst and SebastianKrupinski
as code ownersFebruary 11, 2026 13:06
miaulalala
requested review from
come-nc, icewind1991, leftybournes and salmart-dev
and removed request for
a teamFebruary 11, 2026 13:06
tcitworld
left a comment
Member
There was a problem hiding this comment.
What's the plan regarding the existing IDateTimeZone interface which has similar (but not identical) functions?
Also, should existing uses of OCA\DAV\CalDAV\TimezoneService be replaced straight away with OCP\Calendar\ITimezoneService ?
| interface ITimezoneService { | ||
| public function getUserTimezone(string $userId): ?string; | ||
| public function getDefaultTimezone(): string; |
Member
There was a problem hiding this comment.
This is doing the same thing as IDateTimeZone::getDefaultTimeZone
ContributorAuthor
There was a problem hiding this comment.
True, maybe I can unify the interface.
| * @since 34.0.0 | ||
| */ | ||
| interface ITimezoneService { | ||
| public function getUserTimezone(string $userId): ?string; |
Member
There was a problem hiding this comment.
sounds like IDateTimeZone::getTimeZone
ContributorAuthor
There was a problem hiding this comment.
no, it's a bit more extensive than getTimeZone
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)