Uh oh!
There was an error while loading. Please reload this page.
[stable31] fix(cache): filter out invalid entries in OC\Files\Cache\Wrapper\CacheWrapper::getFolderContentsById - #58285
Merged
Merged
Conversation
OC\Files\Cache\Wrapper\CacheWrapper::getFolderContentsByIdOC\Files\Cache\Wrapper\CacheWrapper::getFolderContentsByIdsusnux
marked this pull request as ready for review
February 16, 2026 13:58
susnux
requested review from
a team, Altahrim, ArtificialOwl, CarlSchwan and provokateurin
and removed request for
a teamFebruary 16, 2026 13:59
susnux
commented
Feb 16, 2026
ContributorAuthor
/backport to master |
susnux
commented
Feb 16, 2026
ContributorAuthor
/backport to stable33 |
susnux
commented
Feb 16, 2026
ContributorAuthor
/backport to stable32 |
Altahrim
approved these changes
Feb 17, 2026
provokateurin
approved these changes
Feb 17, 2026
…heWrapper::getFolderContentsById` Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnuxforce-pushed
the
fix/31-cache-content
branch
from
February 17, 2026 12:11
bb58e47 to
64034f8Comparesusnux
commented
Feb 17, 2026
ContributorAuthor
(removed the now unneeded entry from psalm baseline) |
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Feb 17, 2026
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
See e.g.
ACLCacheWrapperof groupfolders.formatCacheEntryis allowed to return alsofalsebutgetFolderContentsByIdmust not.So we need to filter out those invalid entries.
Checklist
3. to review, feature component)stable32)