Uh oh!
There was an error while loading. Please reload this page.
refactor(workflowengine): Port away from old events - #58600
Open
CarlSchwan wants to merge 1 commit into
Open
Conversation
CarlSchwan
requested review from
a team, blizzz, juliusknorr and nickvergessen
as code ownersFebruary 26, 2026 21:54
CarlSchwan
requested review from
artonge, leftybournes, nfebe and sorbaugh
and removed request for
a teamFebruary 26, 2026 21:54
CarlSchwanforce-pushed
the
carl/workflow-outdated-events
branch
2 times, most recently
from
February 26, 2026 23:25
640c4bf to
0d5c71cComparesusnux
commented
Feb 27, 2026
Contributor
Ci looks unhappy |
CarlSchwanforce-pushed
the
carl/workflow-outdated-events
branch
2 times, most recently
from
March 2, 2026 11:35
faf9ea9 to
554eaf5Comparenickvergessen added a commit
to nextcloud/files_accesscontrol
that referenced
this pull request
Mar 2, 2026
Signed-off-by: Joas Schilling <coding@schilljs.com>
And enforce via static analysis that only new event classes are used. We have to also create a new private event for the workflowengine as the rule matcher is not able to handle multiple nodes at the same time. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwanforce-pushed
the
carl/workflow-outdated-events
branch
from
March 10, 2026 17:40
554eaf5 to
b707513Compareartonge
reviewed
Mar 18, 2026
| new GenericEntityEvent($this->l10n->t('File copied'), self::EVENT_NAMESPACE . 'postCopy'), | ||
| new GenericEntityEvent($this->l10n->t('Tag assigned'), MapperEvent::EVENT_ASSIGN), | ||
| new GenericEntityEvent($this->l10n->t('File created'), NodeCreatedEvent::class), | ||
| new GenericEntityEvent($this->l10n->t('File updated'), NodeUpdatedEvent::class), |
Collaborator
There was a problem hiding this comment.
Isn't it rather the already existing NodeWrittenEvent?
Suggested change
| newGenericEntityEvent($this->l10n->t('File updated'), NodeUpdatedEvent::class), | |
| newGenericEntityEvent($this->l10n->t('File updated'), NodeWrittenEvent::class), |
| * @since 34.0.0 | ||
| */ | ||
| #[Consumable(since: '34.0.0')] | ||
| final class NodeUpdatedEvent extends AbstractNodeEvent { |
Collaborator
There was a problem hiding this comment.
Might be a duplicate of NodeWrittenEvent.
Collaborator
There was a problem hiding this comment.
If we keep both, we better document what is the purpose of each event.
| Util::connectHook('OC_Filesystem', 'post_create', $this, 'postCreate'); | ||
| Util::connectHook('OC_Filesystem', 'update', $this, 'update'); | ||
| Util::connectHook('OC_Filesystem', 'post_update', $this, 'postUpdate'); |
Collaborator
There was a problem hiding this comment.
I wonder if it was left out on purpose.
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
And enforce via static analysis that only new event classes are used.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)