Uh oh!
There was an error while loading. Please reload this page.
[stable33] perf(sharing): Avoid loading all shares from all users when unsharing - #58658
Merged
Conversation
First check which users have a shares and for which providers and then only load these shares. Avoid doing at most 5 SQL queries for each users a share was shared with if there are no shares. Signed-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwanforce-pushed
the
backport/58057/stable33
branch
from
March 2, 2026 11:38
653efb2 to
212ea44CompareCarlSchwan
approved these changes
Mar 2, 2026
CarlSchwan
marked this pull request as ready for review
March 2, 2026 11:40
CarlSchwan
requested review from
Altahrim, ArtificialOwl and icewind1991
and removed request for
a teamMarch 2, 2026 11:40
CarlSchwanforce-pushed
the
backport/58057/stable33
branch
2 times, most recently
from
March 2, 2026 13:09
bfc4183 to
f65314cCompareSigned-off-by: Carl Schwan <carlschwan@kde.org>
CarlSchwanforce-pushed
the
backport/58057/stable33
branch
from
March 2, 2026 15:07
f65314c to
94c4235Comparecristianscheid
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #58057
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.