Skip to content

[stable33] fix(files_sharing): allow strict validation of shares - #58688

Merged
susnux merged 2 commits into
stable33from
backport/882d832
Mar 17, 2026
Merged

[stable33] fix(files_sharing): allow strict validation of shares#58688
susnux merged 2 commits into
stable33from
backport/882d832

Conversation

@susnux

@susnuxsusnux commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

@susnux
susnux requested a review from a team as a code ownerMarch 3, 2026 13:33
@susnux
susnux requested review from artonge, skjnldsv and szaimen and removed request for a teamMarch 3, 2026 13:33
@github-actionsgithub-actionsBot changed the title fix(files_sharing): allow strict validation of shares[stable33] fix(files_sharing): allow strict validation of sharesMar 3, 2026
@susnuxsusnux added bug 3. to review Waiting for reviews labels Mar 3, 2026
@susnuxsusnux added this to the Nextcloud 33.0.1 milestone Mar 3, 2026
@susnux

susnux commented Mar 3, 2026

Copy link
Copy Markdown
ContributorAuthor

/compile

szaimen
szaimen approved these changes Mar 3, 2026
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux

susnux commented Mar 4, 2026

Copy link
Copy Markdown
ContributorAuthor

/compile rebase

@susnux

susnux commented Mar 17, 2026

Copy link
Copy Markdown
ContributorAuthor

/compile rebase

susnuxand others added 2 commits March 17, 2026 12:21
@susnux@nextcloud-command
fix(files_sharing): allow strict validation of shares
b56e0d5
API response sometimes includes `null` for unset, but unset
(`undefined`) is something different than `null`.
So if `null` is passed we mean `undefined` instead.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@nextcloud-command
chore(assets): Recompile assets
7d35db6
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux merged commit 2e32d03 into stable33Mar 17, 2026
199 of 218 checks passed
@susnux
susnux deleted the backport/882d832 branch March 17, 2026 15:37
@skjnldsvskjnldsv mentioned this pull request Mar 18, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szaimenszaimenszaimen approved these changes
@cristianscheidcristianscheidcristianscheid approved these changes
@artongeartongeAwaiting requested review from artongeartonge is a code owner automatically assigned from nextcloud/server-frontend
@skjnldsvskjnldsvAwaiting requested review from skjnldsvskjnldsv is a code owner automatically assigned from nextcloud/server-frontend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 33.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@susnux@szaimen@cristianscheid@nextcloud-command