Skip to content

test(ldap): align expectation for unset ldapUserDisplayName2 with implementation to avoid PHP 8.5 warning - #58813

Merged
blizzz merged 1 commit into
masterfrom
jtr/test-ldap-UserStateUpdate-name2
Jun 18, 2026
Merged

test(ldap): align expectation for unset ldapUserDisplayName2 with implementation to avoid PHP 8.5 warning#58813
blizzz merged 1 commit into
masterfrom
jtr/test-ldap-UserStateUpdate-name2

Conversation

@joshtrichards

@joshtrichardsjoshtrichards commented Mar 9, 2026•
edited
Loading

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Fixes this test warning with PHP 8.5:

7) /home/runner/actions-runner/_work/server/server/apps/user_ldap/lib/Access.php:706
Using null as an array offset is deprecated, use an empty string instead
Triggered by:
* OCA\User_LDAP\Tests\AccessTest::testUserStateUpdate
/home/runner/actions-runner/_work/server/server/apps/user_ldap/tests/AccessTest.php:711

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@joshtrichards
test(user_ldap): return empty string for unset ldapUserDisplayName2 a…
cfd3466
…s per implementation
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichardsjoshtrichards added this to the Nextcloud 34 milestone Mar 9, 2026
@joshtrichardsjoshtrichards added bug 3. to review Waiting for reviews feature: ldap tests Related to tests labels Mar 9, 2026
@joshtrichards

joshtrichards commented Mar 9, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable33

@joshtrichards
joshtrichards marked this pull request as ready for review March 9, 2026 16:27
@joshtrichards
joshtrichards requested a review from a team as a code ownerMarch 9, 2026 16:27
@joshtrichards
joshtrichards requested review from ArtificialOwl, blizzz, leftybournes, nfebe and sorbaugh and removed request for a teamMarch 9, 2026 16:27
@joshtrichardsjoshtrichards changed the title test(user_ldap): return empty string for unset ldapUserDisplayName2 …test(ldap): return empty string for unset ldapUserDisplayName2 as per implementationMar 11, 2026
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2026
Closed
@skjnldsvskjnldsv mentioned this pull request Jun 4, 2026
Merged
This was referenced Jun 5, 2026
Merged
Merged
@susnuxsusnux added the community pull requests from community label Jun 9, 2026
@joshtrichardsjoshtrichards changed the title test(ldap): return empty string for unset ldapUserDisplayName2 as per implementationtest(ldap): align expectation for unset ldapUserDisplayName2 with implementation to avoid PHP 8.5 warningJun 16, 2026
@blizzz
blizzz merged commit 1f74848 into masterJun 18, 2026
193 of 197 checks passed
@blizzz
blizzz deleted the jtr/test-ldap-UserStateUpdate-name2 branch June 18, 2026 13:49
@backportbotbackportbotBot mentioned this pull request Jun 18, 2026
Merged
@CarlSchwan

CarlSchwan commented Jun 18, 2026

Copy link
Copy Markdown
Member

/backport to stable34

@backportbotbackportbotBot mentioned this pull request Jun 18, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Aug 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blizzzblizzzblizzz approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugcommunitypull requests from communityfeature: ldaptestsRelated to tests

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

6 participants

@joshtrichards@CarlSchwan@blizzz@come-nc@susnux@nextcloud-bot