Skip to content

feat: add mailing notifications to calendar delegation - #59232

Closed
GVodyanov wants to merge 4 commits into
masterfrom
feat/add-calendar-delegation-functionality
Closed

feat: add mailing notifications to calendar delegation#59232
GVodyanov wants to merge 4 commits into
masterfrom
feat/add-calendar-delegation-functionality

Conversation

@GVodyanov

@GVodyanovGVodyanov commented Mar 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Needed for nextcloud/calendar#8085

This PR consists of two parts:

  1. feat: notify delegatee of new calendar delegations
  2. fix: make delegated calendar homes discoverable

TODO

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@GVodyanovGVodyanov added the 1. to develop Accepted and waiting to be taken care of label Mar 26, 2026
@GVodyanov
GVodyanovforce-pushed the feat/add-calendar-delegation-functionality branch from 657854e to 8d29369CompareMarch 26, 2026 14:46
GVodyanovand others added 2 commits May 5, 2026 11:40
Signed-off-by: Grigory Vodyanov <scratchx@gmx.com>
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221
hamza221force-pushed the feat/add-calendar-delegation-functionality branch from 8d29369 to 1e1d118CompareMay 5, 2026 09:43
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
@hamza221
hamza221 marked this pull request as ready for review May 6, 2026 15:01
@hamza221
hamza221 requested review from ArtificialOwl, icewind1991, leftybournes and salmart-dev and removed request for a teamMay 6, 2026 15:01
@hamza221hamza221 added 3. to review Waiting for reviews feature: caldav Related to CalDAV internals and removed 1. to develop Accepted and waiting to be taken care of labels May 6, 2026
@ChristophWurst

Copy link
Copy Markdown
Member

#16666 added delegation. Can you update the description to explain what this PR adds on top, and how it can be tested?

@hamza221

Copy link
Copy Markdown
Contributor

I'm going to extract the fix for #42051 in a seprate PR then we rebase this one

@GVodyanov

Copy link
Copy Markdown
ContributorAuthor

#16666 added delegation. Can you update the description to explain what this PR adds on top, and how it can be tested?

  1. Email notifications
  2. Calendar home resolution for proxy principals, so that the delegatee can get the delegator's calendars
  3. ACL on proxy group principals
  4. The trashbin ACL fix that Hamza will now move elsewhere

Correct me if I'm wrong @hamza221

@GVodyanovGVodyanov left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a comment from Sebastian nextcloud/calendar#8085 (comment)

@ChristophWurst

Copy link
Copy Markdown
Member

4. The trashbin ACL fix that Hamza will now move elsewhere

Correct me if I'm wrong @hamza221

Seems to be at #60211 and a requirement for this PR.

I have now updated the PR description for you with this information. Correct it if I got anything wrong.

Since this PR now contains a new feature and fixes, I do wonder if the fixes shouldn't be separate and backported to also fix discovery for older releases that already had delegation.

@GVodyanov

Copy link
Copy Markdown
ContributorAuthor

@copilot resolve the merge conflicts in this pull request

CopilotAI commented May 22, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Done in 095b3a7. I resolved the merge conflict hotspots by aligning the two conflicting files with current master-compatible behavior (TrashbinHome proxy-write ACL and files_versionsprincipalBackend registration), and validated with a merge-tree conflict check plus Code Review/CodeQL.

@GVodyanovGVodyanov changed the title feat: add calendar delegation functionalityfeat: add mailing notifications to calendar delegationMay 22, 2026
@hamza221hamza221 added 2. developing Work in progress and removed 3. to review Waiting for reviews labels May 24, 2026
@hamza221

Copy link
Copy Markdown
Contributor

closed in favor of #60712

@hamza221
hamza221 deleted the feat/add-calendar-delegation-functionality branch May 24, 2026 12:55
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developingWork in progressbugenhancementfeature: caldavRelated to CalDAV internalsfeature: dav

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@GVodyanov@ChristophWurst@hamza221@joshtrichards