Skip to content

fix(SetupChecks): maintenance window length is 4h (not 6h) - #59413

Merged
AndyScherzinger merged 1 commit into
masterfrom
jtr/fix-setupcheck-maintenance-length
Jun 11, 2026
Merged

fix(SetupChecks): maintenance window length is 4h (not 6h)#59413
AndyScherzinger merged 1 commit into
masterfrom
jtr/fix-setupcheck-maintenance-length

Conversation

@joshtrichards

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

$endHour = $startHour + 4;

(Or we increase the implementation to 6 to match; I have no strong opinions either way).

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichardsjoshtrichards added this to the Nextcloud 34 milestone Apr 2, 2026
@joshtrichards
joshtrichards requested a review from a team as a code ownerApril 2, 2026 22:20
@joshtrichards
joshtrichards requested review from Altahrim, come-nc, leftybournes and provokateurin and removed request for a teamApril 2, 2026 22:20
@joshtrichards

Copy link
Copy Markdown
MemberAuthor

/backport to stable33

@joshtrichardsjoshtrichards added the 3. to review Waiting for reviews label Apr 2, 2026

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well add a constant to keep both codes in sync?

@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
@nextcloud-botnextcloud-bot mentioned this pull request Jun 4, 2026
This was referenced Jun 5, 2026
@susnuxsusnux added the community pull requests from community label Jun 9, 2026

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cleaner to add a constant for this.

@AndyScherzinger
AndyScherzinger merged commit d1921c9 into masterJun 11, 2026
176 of 178 checks passed
@AndyScherzinger
AndyScherzinger deleted the jtr/fix-setupcheck-maintenance-length branch June 11, 2026 09:37
@nextcloud-botnextcloud-bot mentioned this pull request Aug 11, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbugcommunitypull requests from communityfeature: settings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@joshtrichards@provokateurin@come-nc@AndyScherzinger@susnux@nextcloud-bot