Skip to content

fix(previews): fix chunking for querybuilder - #59477

Merged
miaulalala merged 2 commits into
masterfrom
fix/noid/preview-scan-bulk-fetch-chunking
May 6, 2026
Merged

fix(previews): fix chunking for querybuilder#59477
miaulalala merged 2 commits into
masterfrom
fix/noid/preview-scan-bulk-fetch-chunking

Conversation

@miaulalala

@miaulalalamiaulalala commented Apr 7, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Fixes#59234 (comment)

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@miaulalalamiaulalala added this to the Nextcloud 34 milestone Apr 7, 2026
@miaulalalamiaulalala self-assigned this Apr 7, 2026
@miaulalala
miaulalala requested a review from a team as a code ownerApril 7, 2026 10:33
@miaulalalamiaulalala added the 3. to review Waiting for reviews label Apr 7, 2026
@miaulalala
miaulalala requested review from CarlSchwan, come-nc, joshtrichards, leftybournes and salmart-dev and removed request for a teamApril 7, 2026 10:33
come-nc
come-nc reviewed Apr 9, 2026
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be cleaner to use a parameter and set it in the loop.
See

server/apps/dav/lib/CalDAV/CalDavBackend.php

Line 2949 in c835064

foreach (array_chunk($ids, 1000) as$chunk) {
for an example

@miaulalala
miaulalala requested a review from come-ncMay 4, 2026 16:59
@miaulalala
miaulalalaforce-pushed the fix/noid/preview-scan-bulk-fetch-chunking branch 2 times, most recently from a5565fa to 70751b6CompareMay 5, 2026 07:52
provokateurin
provokateurin previously requested changes May 6, 2026
View reviewed changes
Comment threadlib/private/Preview/Storage/LocalPreviewStorage.php Outdated
Comment threadlib/private/Preview/Storage/LocalPreviewStorage.php Outdated
@miaulalala
fix(previews): fix chunking for querybuilder
59144ac
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala
fix(previews): use createParameter/setParameter to reuse query in chu…
0681ced
…nk loop
AI-Assisted-By: claude-sonnet-4-6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@miaulalala
miaulalalaforce-pushed the fix/noid/preview-scan-bulk-fetch-chunking branch from 70751b6 to 0681cedCompareMay 6, 2026 08:33
@miaulalala
miaulalala enabled auto-merge May 6, 2026 11:50
@miaulalala
miaulalala merged commit 5d7cdb8 into masterMay 6, 2026
224 of 233 checks passed
@miaulalala
miaulalala deleted the fix/noid/preview-scan-bulk-fetch-chunking branch May 6, 2026 14:27
@nextcloud-botnextcloud-bot mentioned this pull request May 7, 2026
Merged
This was referenced May 12, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 20, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwanCarlSchwanCarlSchwan approved these changes
@max-nextcloudmax-nextcloudmax-nextcloud approved these changes
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@joshtrichardsjoshtrichardsAwaiting requested review from joshtrichards
@come-nccome-ncAwaiting requested review from come-nc
@provokateurinprovokateurinAwaiting requested review from provokateurin

Assignees

@miaulalalamiaulalala

Labels

3. to reviewWaiting for reviewsbugfeature: previews and thumbnails

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

5 participants

@miaulalala@CarlSchwan@provokateurin@come-nc@max-nextcloud