Skip to content

refactor: Add strict property/parameter typing to OCP\HintException - #59713

Merged
susnux merged 1 commit into
masterfrom
jtr/refactor-HintException-typing
Apr 29, 2026
Merged

refactor: Add strict property/parameter typing to OCP\HintException#59713
susnux merged 1 commit into
masterfrom
jtr/refactor-HintException-typing

Conversation

@joshtrichards

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

Changes:

  • Added declare(strict_types=1)
  • Typed constructor params:
  • Typed property with constructor property promotion
  • Simplified getHint() to a direct string check

Why:

  • Stronger static analysis
  • Clearer public API contract
  • Less boilerplate
  • Same runtime behavior for valid callers

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI (yes, but manually reviewed)

Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichardsjoshtrichards added the ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) label Apr 18, 2026
@joshtrichards
joshtrichards marked this pull request as ready for review April 20, 2026 13:27
@joshtrichards
joshtrichards requested a review from a team as a code ownerApril 20, 2026 13:27
@joshtrichards
joshtrichards requested review from artonge, leftybournes, nfebe and salmart-dev and removed request for a teamApril 20, 2026 13:27
@joshtrichardsjoshtrichards added the 3. to review Waiting for reviews label Apr 20, 2026
@joshtrichardsjoshtrichards added this to the Nextcloud 34 milestone Apr 20, 2026
@susnux
susnux merged commit 12e8019 into masterApr 29, 2026
207 of 211 checks passed
@susnux
susnux deleted the jtr/refactor-HintException-typing branch April 29, 2026 12:06
This was referenced Apr 30, 2026
This was referenced May 7, 2026
This was referenced May 15, 2026
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviews♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@joshtrichards@artonge@CarlSchwan@susnux