Uh oh!
There was an error while loading. Please reload this page.
fix: Add missing PasswordConfirmationRequired attributes - #59764
Merged
Conversation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…ctions Register axios password confirmation interceptors in the apps management, admin delegation, admin security, and OAuth2 settings bundles, and pass PwdConfirmationMode.Strict on requests to endpoints protected with #[PasswordConfirmationRequired(strict: true)], so that the user password is verified via Basic auth on the request itself rather than relying on the session timestamp. Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
come-nc
requested review from
CarlSchwan, leftybournes, nfebe, sorbaugh and szaimen
and removed request for
a teamApril 21, 2026 08:21
come-nc
commented
Apr 21, 2026
ContributorAuthor
/compile / |
come-nc
commented
Apr 21, 2026
ContributorAuthor
/backport to stable33 |
come-nc
commented
Apr 21, 2026
ContributorAuthor
/backport to stable32 |
come-nc
commented
Apr 21, 2026
ContributorAuthor
/backport to stable31 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
provokateurin
approved these changes
Apr 21, 2026
provokateurin
enabled auto-merge
April 21, 2026 09:55
come-nc
commented
Apr 21, 2026
ContributorAuthor
Cypress failure is related |
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Apr 21, 2026
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App enabling should require a strict password confirmation.
Checklist
3. to review, feature component)stable32)AI (if applicable)