Skip to content

fix: Harmonize login and passwordless login redirect behavior - #59790

Merged
come-nc merged 4 commits into
masterfrom
fix/fix-passwordless-login-redirect
Apr 29, 2026
Merged

fix: Harmonize login and passwordless login redirect behavior#59790
come-nc merged 4 commits into
masterfrom
fix/fix-passwordless-login-redirect

Conversation

@come-nc

@come-nccome-nc commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Summary

Url should be made absolute in both cases.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@come-nccome-nc added this to the Nextcloud 34 milestone Apr 21, 2026
@come-nc
come-nc requested a review from artongeApril 21, 2026 15:09
@come-nccome-nc self-assigned this Apr 21, 2026
@come-nc
come-nc requested a review from a team as a code ownerApril 21, 2026 15:09
@come-nccome-nc added the 3. to review Waiting for reviews label Apr 21, 2026
@come-nc
come-nc requested review from ArtificialOwl, leftybournes and salmart-dev and removed request for a teamApril 21, 2026 15:09
@come-nc

come-nc commented Apr 21, 2026

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

@come-nc

come-nc commented Apr 21, 2026

Copy link
Copy Markdown
ContributorAuthor

/backport to stable31

@kesselb

This comment was marked as resolved.

Sign in to view
@DorraJaouad
DorraJaouad requested review from a team and provokateurin as code ownersApril 23, 2026 09:41
@DorraJaouad
DorraJaouad requested review from nfebe, sorbaugh and szaimen and removed request for a teamApril 23, 2026 09:41
@come-nc
come-ncforce-pushed the fix/fix-passwordless-login-redirect branch from 89e5d78 to 4f4fbabCompareApril 23, 2026 10:57
@come-nc

come-nc commented Apr 23, 2026

Copy link
Copy Markdown
ContributorAuthor

/backport! to stable33

@backportbotbackportbotBot mentioned this pull request Apr 23, 2026
Closed
@come-nc
come-ncforce-pushed the fix/fix-passwordless-login-redirect branch from 4f4fbab to 5cbe4caCompareApril 23, 2026 13:15
@come-nc

come-nc commented Apr 23, 2026

Copy link
Copy Markdown
ContributorAuthor

/compile /

@come-nc
come-nc enabled auto-merge April 23, 2026 15:44
@come-nc

come-nc commented Apr 27, 2026

Copy link
Copy Markdown
ContributorAuthor

/compile rebase

@nextcloud-command
nextcloud-commandforce-pushed the fix/fix-passwordless-login-redirect branch from 05a1744 to 3b823deCompareApril 27, 2026 09:33
@come-nc

come-nc commented Apr 27, 2026

Copy link
Copy Markdown
ContributorAuthor

/compile rebase

@nextcloud-command
nextcloud-commandforce-pushed the fix/fix-passwordless-login-redirect branch from 20d347c to 1d04d8aCompareApril 27, 2026 12:55
@come-nc

come-nc commented Apr 27, 2026

Copy link
Copy Markdown
ContributorAuthor

login/login.cy.ts is failing so I guess it is related but locally the cypress test passes, and the screenshot is weird, it looks like the dashboard app is missing.

come-ncand others added 4 commits April 28, 2026 10:00
@come-nc
fix: Always redirect to an absolute URL
19c7ac9
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command@come-nc
chore(assets): Recompile assets
53def00
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@come-nc
chore: Fix npm lint issues in PasswordLessLoginForm.vue
6ced1ce
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command@come-nc
chore(assets): Recompile assets
ce30e42
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@come-nc
come-ncforce-pushed the fix/fix-passwordless-login-redirect branch from 1d04d8a to ce30e42CompareApril 28, 2026 08:00
@come-nc
come-nc merged commit c332ca7 into masterApr 29, 2026
152 of 157 checks passed
@come-nc
come-nc deleted the fix/fix-passwordless-login-redirect branch April 29, 2026 21:09
This was referenced Apr 29, 2026
Closed
Closed
@nextcloud-botnextcloud-bot mentioned this pull request Apr 30, 2026
Merged
@come-nc

come-nc commented Apr 30, 2026

Copy link
Copy Markdown
ContributorAuthor

/backport to stable33

@backportbotbackportbotBot mentioned this pull request Apr 30, 2026
Merged
susnux
susnux reviewed Apr 30, 2026
View reviewed changes
Comment threadcore/src/components/login/PasswordLessLoginForm.vue
logger.debug('Logged in redirecting')
if (redirectUrl) {
if (redirectUrl.charAt(0) !== '/') {
redirectUrl = '/' + redirectUrl

@susnuxsusnuxApr 30, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reassign a const? 👀

@come-nccome-nc mentioned this pull request Apr 30, 2026
Merged
7 tasks
This was referenced May 5, 2026
Merged
Merged
This was referenced May 12, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 20, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux left review comments
@kesselbkesselbkesselb approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@artongeartongeAwaiting requested review from artonge
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl was automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev was automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes was automatically assigned from nextcloud/server-backend
@provokateurinprovokateurinAwaiting requested review from provokateurin
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@szaimenszaimenAwaiting requested review from szaimenszaimen is a code owner automatically assigned from nextcloud/server-frontend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@come-nccome-nc

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

5 participants

@come-nc@kesselb@susnux@CarlSchwan@nextcloud-command