Skip to content

feat(ldap): Allow to search one user by one of its LDAP attribute - #59928

Merged
CarlSchwan merged 1 commit into
masterfrom
carl/ldap-search-one-by-attribute
May 12, 2026
Merged

feat(ldap): Allow to search one user by one of its LDAP attribute#59928
CarlSchwan merged 1 commit into
masterfrom
carl/ldap-search-one-by-attribute

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented Apr 27, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Summary

Part of #55284

Alternative to #56721

Related PRs:

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwanCarlSchwan added this to the Nextcloud 34 milestone Apr 27, 2026
@CarlSchwanCarlSchwan self-assigned this Apr 27, 2026
@CarlSchwan
CarlSchwan requested a review from a team as a code ownerApril 27, 2026 12:05
@CarlSchwan
CarlSchwan requested review from come-nc, nfebe, salmart-dev and sorbaugh and removed request for a teamApril 27, 2026 12:05
@CarlSchwan
CarlSchwanforce-pushed the carl/ldap-search-one-by-attribute branch from f8d70a0 to 15f4ff4CompareApril 27, 2026 16:05
@CarlSchwanCarlSchwan mentioned this pull request Apr 27, 2026
Draft
2 tasks
come-nc
come-nc requested changes Apr 28, 2026
View reviewed changes
Comment threadlib/public/LDAP/Exceptions/MultipleUsersReturnedException.php
Comment threadapps/user_ldap/lib/User_LDAP.php
Comment threadapps/user_ldap/lib/User_LDAP.php Outdated
@CarlSchwan
CarlSchwanforce-pushed the carl/ldap-search-one-by-attribute branch 3 times, most recently from 9bc4600 to 5388b92CompareMay 6, 2026 13:30
come-nc
come-nc reviewed May 7, 2026
View reviewed changes
Comment threadapps/user_ldap/lib/User_LDAP.php Outdated
@CarlSchwan
CarlSchwanforce-pushed the carl/ldap-search-one-by-attribute branch from 5388b92 to c47f679CompareMay 7, 2026 10:57
come-nc
come-nc reviewed May 7, 2026
View reviewed changes
Comment threadapps/user_ldap/lib/User_LDAP.php Outdated
@CarlSchwan
CarlSchwanforce-pushed the carl/ldap-search-one-by-attribute branch from c47f679 to 1b35170CompareMay 7, 2026 15:43
come-nc
come-nc approved these changes May 11, 2026
View reviewed changes

@come-nccome-nc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autoloader needs fixing.

@CarlSchwan
feat(ldap): Allow to search one user by one of its LDAP attribute
acceeb6
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwanforce-pushed the carl/ldap-search-one-by-attribute branch from 1b35170 to acceeb6CompareMay 11, 2026 10:41
@CarlSchwan
CarlSchwan enabled auto-merge May 11, 2026 14:25
@CarlSchwan
CarlSchwan merged commit 4eb8bc8 into masterMay 12, 2026
216 of 232 checks passed
@CarlSchwan
CarlSchwan deleted the carl/ldap-search-one-by-attribute branch May 12, 2026 12:34
@artongeartonge added the pending documentation This pull request needs an associated documentation update label May 12, 2026
This was referenced May 12, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 20, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@cristianscheidcristianscheidcristianscheid approved these changes
@come-nccome-nccome-nc approved these changes
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@CarlSchwanCarlSchwan

Labels

3. to reviewWaiting for reviewsfeature: ldapfeature: users and groupspending documentationThis pull request needs an associated documentation update

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan@Altahrim@cristianscheid@come-nc@artonge