Skip to content

feat(cron): prevent pending transactions forgotten by a job - #59934

Merged
come-nc merged 1 commit into
masterfrom
feat/prevent-pending-trx-cron
Apr 30, 2026
Merged

feat(cron): prevent pending transactions forgotten by a job#59934
come-nc merged 1 commit into
masterfrom
feat/prevent-pending-trx-cron

Conversation

@Altahrim

@AltahrimAltahrim commented Apr 27, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

A job can forget to close its transaction so all following jobs will operate in a transaction.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@AltahrimAltahrim added this to the Nextcloud 34 milestone Apr 27, 2026
@AltahrimAltahrim self-assigned this Apr 27, 2026
@AltahrimAltahrim added 2. developing Work in progress php Pull requests that update Php code labels Apr 27, 2026
ChristophWurst
ChristophWurst reviewed Apr 27, 2026
View reviewed changes
Comment threadcore/Service/CronService.php Outdated
@Altahrim
feat(cron): prevent pending transactions forgotten by a job
b8345de
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
@Altahrim
Altahrimforce-pushed the feat/prevent-pending-trx-cron branch from c11d0d1 to b8345deCompareApril 27, 2026 14:45
@AltahrimAltahrim added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 28, 2026
@Altahrim
Altahrim marked this pull request as ready for review April 28, 2026 08:56
@Altahrim
Altahrim requested a review from a team as a code ownerApril 28, 2026 08:56
@Altahrim
Altahrim requested review from come-nc, icewind1991, salmart-dev and sorbaugh and removed request for a teamApril 28, 2026 08:57
@artongeartonge linked an issue Apr 30, 2026 that may be closed by this pull request
[RFC] Admin-tooling / Background job improvements #52877
Open
@come-nc
come-nc merged commit 5b7cd41 into masterApr 30, 2026
189 of 191 checks passed
@come-nc
come-nc deleted the feat/prevent-pending-trx-cron branch April 30, 2026 16:26
This was referenced May 5, 2026
Merged
Merged
This was referenced May 12, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 20, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
@provokateurinprovokateurin mentioned this pull request Jul 16, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristophWurstChristophWurstChristophWurst left review comments
@artongeartongeartonge approved these changes
@come-nccome-nccome-nc approved these changes
@icewind1991icewind1991Awaiting requested review from icewind1991icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@AltahrimAltahrim

Labels

3. to reviewWaiting for reviewsphpPull requests that update Php code

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

[RFC] Admin-tooling / Background job improvements

4 participants

@Altahrim@ChristophWurst@artonge@come-nc