Skip to content

Fix since checker - #59940

Merged
nickvergessen merged 3 commits into
masterfrom
bug/noid/fix-since-checker
May 7, 2026
Merged

Fix since checker#59940
nickvergessen merged 3 commits into
masterfrom
bug/noid/fix-since-checker

Conversation

@kesselb

@kesselbkesselb commented Apr 27, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

The imports were missing, hence the checks not executed.

Ignoring since for private methods.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@kesselbkesselb self-assigned this Apr 27, 2026
@kesselbkesselb added the bug label Apr 27, 2026
@kesselb
kesselb requested review from ArtificialOwl, provokateurin, salmart-dev and sorbaugh and removed request for a teamApril 27, 2026 16:17
@kesselbkesselb added the 3. to review Waiting for reviews label Apr 27, 2026
kesselb
kesselb commented Apr 27, 2026
View reviewed changes
Comment threadlib/public/AppFramework/PublicShareController.php
abstract class PublicShareController extends Controller {

/**
* @since 33.0.0

@kesselbkesselbApr 27, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs adjustment on backport

kesselb
kesselb commented Apr 27, 2026
View reviewed changes
Comment threadlib/public/AppFramework/PublicShareController.php
/**
* Validate the token and password hash stored in session
*
* @since 33.0.0

@kesselbkesselbApr 27, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs adjustment on backport

kesselb
kesselb commented Apr 27, 2026
View reviewed changes
Comment threadlib/public/AppFramework/PublicShareController.php
/**
* Store the token and password hash in session
*
* @since 33.0.0

@kesselbkesselbApr 27, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs adjustment on backport

kesselb
kesselb commented Apr 27, 2026
View reviewed changes
Comment threadlib/public/Files/DavUtil.php
}

/**
* @since 34.0.0

@kesselbkesselbApr 27, 2026

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs adjustment on backport

nickvergessen
nickvergessen reviewed Apr 27, 2026
View reviewed changes
Comment threadlib/public/AppFramework/Attribute/ASince.php
@nickvergessen

nickvergessen commented Apr 28, 2026

Copy link
Copy Markdown
Member
Error: apps/comments/lib/Activity/Listener.php:32:15: DeprecatedMethod: The method OCP\Comments\CommentsEvent::getEvent has been marked as deprecated (see https://psalm.dev/001)
Error: apps/comments/lib/Listener/CommentsEventListener.php:37:24: DeprecatedMethod: The method OCP\Comments\CommentsEvent::getEvent has been marked as deprecated (see https://psalm.dev/001)
Error: apps/comments/lib/Notification/Listener.php:43:16: DeprecatedMethod: The method OCP\Comments\CommentsEvent::getEvent has been marked as deprecated (see https://psalm.dev/001)
Error: apps/comments/lib/Notification/Listener.php:44:16: DeprecatedMethod: The method OCP\Comments\CommentsEvent::getEvent has been marked as deprecated (see https://psalm.dev/001)

@kesselb
fix(since): Import PhpParser classes
fd8d787
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
fix(since): Ignore private methods in OCP
aee960c
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
docs(ocp): Add since tag
25ca85e
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb
kesselbforce-pushed the bug/noid/fix-since-checker branch from 6e2ed11 to 25ca85eCompareApril 28, 2026 09:17
@nickvergessennickvergessen added this to the Nextcloud 34 milestone Apr 28, 2026
@nickvergessen
nickvergessen merged commit c1ab99e into masterMay 7, 2026
194 of 200 checks passed
@nickvergessen
nickvergessen deleted the bug/noid/fix-since-checker branch May 7, 2026 09:25
@nextcloud-botnextcloud-bot mentioned this pull request May 7, 2026
Merged
@kesselb

kesselb commented May 7, 2026

Copy link
Copy Markdown
ContributorAuthor

/backport to stable33

@backportbotbackportbotBot mentioned this pull request May 7, 2026
Merged
3 tasks
@kesselbkesselb mentioned this pull request May 7, 2026
Merged
7 tasks
This was referenced May 12, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 20, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@SebastianKrupinskiSebastianKrupinskiAwaiting requested review from SebastianKrupinskiSebastianKrupinski is a code owner
@tcitworldtcitworldAwaiting requested review from tcitworldtcitworld is a code owner
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@provokateurinprovokateurinAwaiting requested review from provokateurinprovokateurin is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@kesselbkesselb

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

3 participants

@kesselb@nickvergessen@ChristophWurst