Uh oh!
There was an error while loading. Please reload this page.
refactor: Cleanup application namespace handling - #59977
Merged
Merged
Conversation
come-nc
marked this pull request as ready for review
April 28, 2026 15:57
come-nc
requested review from
Altahrim, icewind1991, leftybournes and salmart-dev
and removed request for
a teamApril 28, 2026 15:57
ChristophWurst
approved these changes
Apr 28, 2026
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
Nice!
The two new methods look very testable 🫣
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+376
to
+389
| /** | ||
| * Get the app namespace | ||
| * | ||
| * @since 34.0.0 | ||
| */ | ||
| public function getAppNamespace(string $appId): string; | ||
| /** | ||
| * Get the app id for this namespace | ||
| * | ||
| * @since 34.0.0 | ||
| */ | ||
| public function getAppFromNamespace(string $className): ?string; |
There was a problem hiding this comment.
new public API -> needs docs
4 tasks
come-ncforce-pushed
the
fix/clean-app-namespace-handling
branch
from
May 7, 2026 14:21
20dc0f8 to
7264a5eComparecome-ncforce-pushed
the
fix/clean-app-namespace-handling
branch
from
May 7, 2026 15:51
7264a5e to
95567caCompareSigned-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-ncforce-pushed
the
fix/clean-app-namespace-handling
branch
from
May 11, 2026 12:53
95567ca to
6664f62CompareCarlSchwan
approved these changes
May 11, 2026
Uh oh!
There was an error while loading. Please reload this page.
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cleanup application namespace handling.
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)