Skip to content

Quota wrapper fixes - #59995

Merged
Altahrim merged 3 commits into
masterfrom
quota-writestream-fopen
May 4, 2026
Merged

Quota wrapper fixes#59995
Altahrim merged 3 commits into
masterfrom
quota-writestream-fopen

Conversation

@icewind1991

@icewind1991icewind1991 commented Apr 29, 2026•
edited
Loading

Copy link
Copy Markdown
Member
  • Block creating empty files trough fopen
  • Apply quota on writeStream
  • Resolves: #

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@icewind1991icewind1991 added this to the Nextcloud 34 milestone Apr 29, 2026
@icewind1991
icewind1991 requested a review from a team as a code ownerApril 29, 2026 17:17
@icewind1991icewind1991 added the 3. to review Waiting for reviews label Apr 29, 2026
@icewind1991
icewind1991 requested review from Altahrim, CarlSchwan, leftybournes and salmart-dev and removed request for a teamApril 29, 2026 17:17
@icewind1991

icewind1991 commented Apr 29, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable33

@icewind1991

icewind1991 commented Apr 29, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable32

@icewind1991
icewind1991force-pushed the quota-writestream-fopen branch 5 times, most recently from 1cddd3d to 1abb776CompareApril 30, 2026 16:09
@icewind1991
fix: block writing empty files with 0 quota
f3a5bc8
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: apply quota with writeStream
9f5535d
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
fix: translate NotEnoughSpaceException to dav exception
7c4b601
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
icewind1991force-pushed the quota-writestream-fopen branch from 1abb776 to 7c4b601CompareMay 2, 2026 12:04
@Altahrim

Altahrim commented May 4, 2026

Copy link
Copy Markdown
Collaborator

Unrelated CI

@Altahrim
Altahrim merged commit aa797a3 into masterMay 4, 2026
207 of 213 checks passed
@Altahrim
Altahrim deleted the quota-writestream-fopen branch May 4, 2026 08:06
This was referenced May 4, 2026
Merged
Draft
This was referenced May 5, 2026
Merged
Merged
This was referenced May 12, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 20, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
@provokateurinprovokateurin mentioned this pull request Jun 3, 2026
Open
8 tasks
@joshtrichardsjoshtrichards mentioned this pull request Jun 7, 2026
Draft
9 tasks
This was referenced Aug 9, 2026
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AltahrimAltahrimAltahrim approved these changes
@CarlSchwanCarlSchwanCarlSchwan approved these changes
@salmart-devsalmart-devAwaiting requested review from salmart-devsalmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991@Altahrim@CarlSchwan