Skip to content

build: harden module name generation - #59996

Merged
susnux merged 2 commits into
masterfrom
chore/harden-vite
Apr 29, 2026
Merged

build: harden module name generation#59996
susnux merged 2 commits into
masterfrom
chore/harden-vite

Conversation

@susnux

@susnuxsusnux commented Apr 29, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

If code is used by multiple entry points of multiple apps make sure we always find a correct module name.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@susnux
build: harden module name generation
04c66dc
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
susnux requested a review from a team as a code ownerApril 29, 2026 17:22
@susnux
susnux requested review from nfebe, sorbaugh and szaimen and removed request for a teamApril 29, 2026 17:23
@susnuxsusnux added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Apr 29, 2026
@susnuxsusnux added this to the Nextcloud 34 milestone Apr 29, 2026
@susnuxsusnux mentioned this pull request Apr 29, 2026
Merged
6 tasks
szaimen
szaimen approved these changes Apr 29, 2026
View reviewed changes

@szaimenszaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@susnux

susnux commented Apr 29, 2026

Copy link
Copy Markdown
ContributorAuthor

/compile

@susnux
susnux requested review from CarlSchwan and removed request for sorbaughApril 29, 2026 17:58
@nextcloud-command
chore(assets): Recompile assets
4431f30
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@susnux
susnux merged commit be5d980 into masterApr 29, 2026
141 of 144 checks passed
@susnux
susnux deleted the chore/harden-vite branch April 29, 2026 19:55
This was referenced Apr 30, 2026
Merged
Merged
This was referenced May 7, 2026
Merged
Merged
This was referenced May 15, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pringelmannpringelmannpringelmann approved these changes
@skjnldsvskjnldsvskjnldsv approved these changes
@szaimenszaimenszaimen approved these changes
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-frontend
@artongeartongeAwaiting requested review from artonge
@CarlSchwanCarlSchwanAwaiting requested review from CarlSchwan

Assignees

No one assigned

Labels

3. to reviewWaiting for reviews♻️ refactorRefactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

5 participants

@susnux@pringelmann@skjnldsv@szaimen@nextcloud-command