Skip to content

fix: Dispatch old comment events - #60137

Merged
CarlSchwan merged 3 commits into
masterfrom
carl/commnent-event
May 5, 2026
Merged

fix: Dispatch old comment events#60137
CarlSchwan merged 3 commits into
masterfrom
carl/commnent-event

Conversation

@CarlSchwan

@CarlSchwanCarlSchwan commented May 4, 2026•
edited
Loading

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwanCarlSchwan added this to the Nextcloud 34 milestone May 4, 2026
@CarlSchwanCarlSchwan self-assigned this May 4, 2026
@CarlSchwan
CarlSchwan requested a review from a team as a code ownerMay 4, 2026 10:49
@CarlSchwan
CarlSchwan requested review from ArtificialOwl, leftybournes, nfebe and sorbaugh and removed request for a teamMay 4, 2026 10:49
@CarlSchwanCarlSchwan mentioned this pull request May 4, 2026
Merged
7 tasks
come-nc
come-nc reviewed May 4, 2026
View reviewed changes
Comment threadapps/comments/lib/Listener/CommentsEventListener.php
@nickvergessen

nickvergessen commented May 4, 2026

Copy link
Copy Markdown
Member

Failing tests related

CarlSchwanand others added 3 commits May 5, 2026 12:30
@CarlSchwan
fix: Dispatch old comment events
da5c8b7
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan@come-nc
chore: Add comment about deprecation
a44deac
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan
fix(tests): Adapt tests for comments
e6a3b68
And make sure these are now covered by psalm
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwanforce-pushed the carl/commnent-event branch from 96f7c55 to e6a3b68CompareMay 5, 2026 10:59
@CarlSchwan
CarlSchwan enabled auto-merge May 5, 2026 12:07
@CarlSchwan

CarlSchwan commented May 5, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable33

@CarlSchwan
CarlSchwan merged commit ff07c99 into masterMay 5, 2026
213 of 217 checks passed
@CarlSchwan
CarlSchwan deleted the carl/commnent-event branch May 5, 2026 12:30
@backportbotbackportbotBot mentioned this pull request May 5, 2026
Merged
This was referenced May 5, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 12, 2026
Merged
This was referenced May 15, 2026
Merged
Merged
@nextcloud-botnextcloud-bot mentioned this pull request May 27, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnuxsusnuxsusnux approved these changes
@miaulalalamiaulalalamiaulalala approved these changes
@come-nccome-nccome-nc approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@nfebenfebeAwaiting requested review from nfebenfebe is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@sorbaughsorbaughAwaiting requested review from sorbaughsorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@CarlSchwanCarlSchwan

Labels

bugregression

Projects

None yet

Milestone

Nextcloud 34

Development

Successfully merging this pull request may close these issues.

5 participants

@CarlSchwan@nickvergessen@susnux@miaulalala@come-nc