Skip to content

[stable32] fix(core): use btoa() instead of window.Buffer.from() for base64 encoding - #60158

Merged
nickvergessen merged 2 commits into
stable32from
backport/60148/stable32
May 6, 2026
Merged

[stable32] fix(core): use btoa() instead of window.Buffer.from() for base64 encoding#60158
nickvergessen merged 2 commits into
stable32from
backport/60148/stable32

Conversation

@backportbot

@backportbotbackportbotBot commented May 5, 2026

Copy link
Copy Markdown

Backport of #60148

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Review and verify the backported changes
  • Remove all the empty commits
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbotbackportbotBot added this to the Nextcloud 32.0.10 milestone May 5, 2026
@miaulalala
miaulalalaforce-pushed the backport/60148/stable32 branch from a991cf6 to c3bf6a1CompareMay 5, 2026 07:39
@miaulalala
miaulalala marked this pull request as ready for review May 5, 2026 07:39
@miaulalala
miaulalala requested a review from a team as a code ownerMay 5, 2026 07:39
@miaulalala
miaulalala requested review from sorbaugh and szaimen and removed request for a teamMay 5, 2026 07:39
@miaulalala

Copy link
Copy Markdown
Contributor

/compile amend

…ding
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the backport/60148/stable32 branch from c3bf6a1 to b56334cCompareMay 5, 2026 08:07
@miaulalala
miaulalala requested a review from a team as a code ownerMay 5, 2026 20:19
@miaulalala
miaulalala requested review from ArtificialOwl, leftybournes and nfebe and removed request for a teamMay 5, 2026 20:19
@miaulalala
miaulalalaforce-pushed the backport/60148/stable32 branch from dfe958d to 82d240cCompareMay 5, 2026 20:21
@miaulalala

Copy link
Copy Markdown
Contributor

/compile amend

- Add Electron to supported browsers regex so Electron-based environments
(including Cypress) are not redirected to the unsupported browser page.
The browserslist-useragent-regexp 4.1.4 upgrade stopped matching Electron
implicitly; this mirrors the existing AscDesktopEditor special-case.
- Fix TextProcessing mock: deleteOlderThan() returns int, not void.
PHP 8.4 strict mock type enforcement causes a TypeError when the
callback is declared void.
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command
nextcloud-commandforce-pushed the backport/60148/stable32 branch from 82d240c to 24efb20CompareMay 5, 2026 20:43
@nickvergessen
nickvergessen merged commit 5f38893 into stable32May 6, 2026
203 of 207 checks passed
@nickvergessen
nickvergessen deleted the backport/60148/stable32 branch May 6, 2026 10:59
@nextcloud-botnextcloud-bot mentioned this pull request May 19, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsAI assistedbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@miaulalala@nickvergessen