fix(core): app menu launcher tile icon, dark mode, and hyphenation

[pringelmann]

Summary

Post-merge fixes to waffle menu:

• Fix incorrect + icon url
• Fix + icon not adapting to dark mode
• (partial) fix for long app name hyphenation

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[nickvergessen]

Having #FFFFFF with darkmode does not work properly

[nickvergessen]

Actually --color-primary-element is FFFFFF which is okay on dark mode, so I guess the icons should be black/dark in those cases? Problem is in

server/core/src/components/AppItem.vue

Lines 128 to 131 in 84a99e6

	// Force the icon to white on the colored circle, then apply the
	// same vertical alpha gradient (--header-menu-icon-mask) used in
	// the header so icons read consistently across the design.
	filter: brightness(0) invert(1);

[kra-mo]

I guess the icons should be black/dark in those cases

The idea was that instead of changing the foreground color, the background color should always stay the same as it is in light mode. But I think this is known by @pringelmann, I don't think this should block this unrelated fix.

[pringelmann]

@nickvergessen yes general dark mode compatibility is high on my TODO list. I will open successive PRs in the coming days to resolve these issues.

[susnux]

The idea was that instead of changing the foreground color, the background color should always stay the same as it is in light mode

I think its more about if you set you primary color to #ffffff or a very light color.
So the icons should have proper filter:

- filter: brightness(0) invert(1); + filter: var(--primary-invert-if-bright);

[susnux]

(icons are bright by default so they need to invert to black if the primary background is bright)

[pringelmann]

Icon color fixed

[nickvergessen]

My thinking was that icons might not always be white

It's kind of an implizit requirement since a long time and how the old navigation was also treating (and inverting) them in the row and the overflow menu 🙈
Thanks for addressing

[pringelmann]

@nickvergessen if you're happy with the change could you please approve? Merge is blocked by your change request

Dismissing