Skip to content

[stable31] fix(core): prompt for password once when installing recommended apps - #60238

Merged
artonge merged 1 commit into
stable31from
backport/60165/stable31
Jun 3, 2026
Merged

[stable31] fix(core): prompt for password once when installing recommended apps#60238
artonge merged 1 commit into
stable31from
backport/60165/stable31

Conversation

@backportbot

@backportbotbackportbotBot commented May 8, 2026

Copy link
Copy Markdown

Backport of #60165

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@pringelmann

pringelmann commented May 8, 2026

Copy link
Copy Markdown
Contributor

@come-nc Not sure what to do here: the original fix was a security hardening we backported to 31 (#59812). This PR is the follow-up that makes that hardening usable in the recommended-apps installer (otherwise users get prompted N times). Strictly a UX completion, not a security fix on its own - does it still qualify for EOL branches under the hardening backport window, or only for Enterprise on request? installing recommended apps is not possible at all, so this should be merged.

@pringelmann
pringelmann requested a review from come-ncMay 11, 2026 09:25
@pringelmann
pringelmannforce-pushed the backport/60165/stable31 branch from 59e2478 to 6043f8eCompareMay 14, 2026 06:30
@pringelmann
pringelmann marked this pull request as ready for review May 15, 2026 13:26
@pringelmann
pringelmannforce-pushed the backport/60165/stable31 branch 3 times, most recently from d00d2b9 to abb2546CompareMay 22, 2026 09:19
Wire the password-confirmation interceptors into the recommendedapps
entry point and switch the installer to a single bulk enable call so
the strict password confirmation on enableApps is satisfied.
Fixes#60068
-e
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
@pringelmann
pringelmannforce-pushed the backport/60165/stable31 branch from abb2546 to 01c829dCompareJune 3, 2026 07:29
@artonge
artonge merged commit 38b38c3 into stable31Jun 3, 2026
119 of 128 checks passed
@artonge
artonge deleted the backport/60165/stable31 branch June 3, 2026 13:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@pringelmann@susnux@artonge