Uh oh!
There was an error while loading. Please reload this page.
fix(settings): clear NcAppNavigation toggle overhang - #60596
Merged
AndyScherzinger merged 1 commit intoJun 11, 2026
Conversation
pringelmann
marked this pull request as ready for review
May 20, 2026 08:14
pringelmann
requested review from
kra-mo, nfebe, skjnldsv, sorbaugh and susnux
and removed request for
a teamMay 20, 2026 08:14
susnux
reviewed
May 20, 2026
Merged
Closed
pringelmannforce-pushed
the
fix/settings-clear-app-navigation-toggle-overhang
branch
from
June 8, 2026 15:36
238625f to
45aa748CompareCarlSchwan
approved these changes
Jun 11, 2026
kra-mo
approved these changes
Jun 11, 2026
Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
pringelmannforce-pushed
the
fix/settings-clear-app-navigation-toggle-overhang
branch
from
June 11, 2026 12:35
45aa748 to
ca950f7Comparesusnux
approved these changes
Jun 11, 2026
susnux
left a comment
Contributor
There was a problem hiding this comment.
I think a heading that is indented like in other apps would look better then wasted space on the side, but ok 😅
pringelmann
commented
Jun 11, 2026
ContributorAuthor
The wasted space on the side is gone. We now only move the title down a little bit. Not ideal, but I would prefer to find a different design solution than try to get all first titles on all settings pages indented. |
Uh oh!
There was an error while loading. Please reload this page.
AndyScherzinger
deleted the
fix/settings-clear-app-navigation-toggle-overhang
branch
June 11, 2026 21:25
pringelmann
commented
Jun 12, 2026
ContributorAuthor
/backport to stable34 |
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Note
This PR was updated with a simpler solution, and its companion
nextcloud-vuePR was closed.The
NcAppNavigationTogglebutton overlaps the start of section content on Nextcloud settings pages. This PR adds a extra top padding to all settings pages so title clears the toggle.The toggle still overlaps content on scroll. This an acceptable trade-off until we have a better design solution for floating action bars.
Preview link
Checklist
stable34where theNcAppNavigationmigration landed