Skip to content

fix(Storage): use proxyexclude parameter in DAV client - #60787

Merged
susnux merged 3 commits into
masterfrom
jtr/fix-storage-dav-client-proxyexclude
Jun 2, 2026
Merged

fix(Storage): use proxyexclude parameter in DAV client#60787
susnux merged 3 commits into
masterfrom
jtr/fix-storage-dav-client-proxyexclude

Conversation

@joshtrichards

@joshtrichardsjoshtrichards commented May 27, 2026

Copy link
Copy Markdown
Member

Summary

The DAV backend uses Sabre \DAV\Client rather than our Guzzle wrapper. This adds support for the proxyexclude directive to the Sabre client.

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@joshtrichards

joshtrichards commented May 27, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable34

@joshtrichards

joshtrichards commented May 27, 2026

Copy link
Copy Markdown
MemberAuthor

/backport to stable33

@joshtrichards
joshtrichards marked this pull request as ready for review May 27, 2026 21:14
@joshtrichards
joshtrichards requested a review from a team as a code ownerMay 27, 2026 21:14
@joshtrichards
joshtrichards requested review from ArtificialOwl, come-nc, leftybournes and provokateurin and removed request for a teamMay 27, 2026 21:15
@joshtrichardsjoshtrichards mentioned this pull request May 27, 2026
Closed
8 tasks
provokateurin
provokateurin approved these changes May 28, 2026
View reviewed changes
Comment threadlib/private/Files/Storage/DAV.php Outdated
@joshtrichardsjoshtrichards added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 28, 2026
@joshtrichardsjoshtrichards added this to the Nextcloud 35 milestone May 28, 2026
joshtrichardsand others added 3 commits May 29, 2026 11:41
@joshtrichards
fix(Storage): use proxyexclude parameter in DAV client
2771543
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
chore(DAV): fixup for lint
d68a7f0
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards@provokateurin
chore(DAV): fixup proxyexclude default value check
a494fcd
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards
joshtrichardsforce-pushed the jtr/fix-storage-dav-client-proxyexclude branch from 1253151 to a494fcdCompareMay 29, 2026 15:41
@susnux
susnux merged commit ce3b3b7 into masterJun 2, 2026
215 of 231 checks passed
@susnux
susnux deleted the jtr/fix-storage-dav-client-proxyexclude branch June 2, 2026 16:02
This was referenced Jun 2, 2026
Merged
Merged
@kyteinsky

kyteinsky commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

/backport to stable32

@backportbotbackportbotBot mentioned this pull request Jul 10, 2026
Merged
@nextcloud-botnextcloud-bot mentioned this pull request Aug 11, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CarlSchwanCarlSchwanCarlSchwan approved these changes
@provokateurinprovokateurinprovokateurin approved these changes
@ArtificialOwlArtificialOwlAwaiting requested review from ArtificialOwlArtificialOwl is a code owner automatically assigned from nextcloud/server-backend
@leftybournesleftybournesAwaiting requested review from leftybournesleftybournes is a code owner automatically assigned from nextcloud/server-backend
@come-nccome-ncAwaiting requested review from come-nccome-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsbugfeature: davfeature: external storage

Projects

None yet

Milestone

Nextcloud 35

Development

Successfully merging this pull request may close these issues.

[Bug]: External storage app ignoring proxyexclude

5 participants

@joshtrichards@kyteinsky@CarlSchwan@provokateurin@susnux